Bug 161352

Summary: Macro recording: all .uno:ChangeCase* command uses are written as rem comment lines
Product: LibreOffice Reporter: Stéphane Guillou (stragu) <stephane.guillou>
Component: BASICAssignee: Andreas Heinisch <andreas.heinisch>
Status: RESOLVED FIXED    
Severity: normal    
Priority: medium    
Version: Inherited From OOo   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
URL: https://forum.openoffice.org/en/forum/viewtopic.php?t=38378
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=38955
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 64314    

Description Stéphane Guillou (stragu) 2024-05-31 03:41:44 UTC 
Steps:
1. Turn macro recording on in Tools > Options > LibreOffice > Advanced
2. Add sample text to Writer document
3. Tools > Macros > Record macros
4. Select some text, run the six case options from the Format > Text submenu
5. Stop the recording, look at recorded macro

All the following UNO commands are commented out as "rem" lines:

rem dispatcher.executeDispatch(document, ".uno:ChangeCaseToUpper", "", 0, Array())
rem dispatcher.executeDispatch(document, ".uno:ChangeCaseToLower", "", 0, Array())
rem dispatcher.executeDispatch(document, ".uno:ChangeCaseRotateCase", "", 0, Array())
rem dispatcher.executeDispatch(document, ".uno:ChangeCaseToSentenceCase", "", 0, Array())
rem dispatcher.executeDispatch(document, ".uno:ChangeCaseToTitleCase", "", 0, Array())
rem dispatcher.executeDispatch(document, ".uno:ChangeCaseToToggleCase", "", 0, Array())

None of the other commands in that submenu are commented out in a recorded macro.

Bug 38955's fix might help: https://cgit.freedesktop.org/libreoffice/calc/commit/?id=e6ffcc9e12567dbff3197d3976339aab59456107

Repro in recent daily build:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6084962f93efc005b6827edceae12d3170f17ccd
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

...as well as OOo 3.3 -> inherited.

(Thanks L.J. for pointing that out on Mastodon!)
Comment 1 Andreas Heinisch 2024-06-12 06:55:51 UTC 
Repro in:
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: d52d82140e14d75487243c8d57dbb88e6a968c59
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL threaded
Comment 2 Commit Notification 2024-06-12 11:50:23 UTC 
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b0aff34ccb12e1af815a059957d7c4f6a14eeaea

tdf#161352 - Set ChangeCase* requests as done for macro recorder

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-06-13 08:38:24 UTC 
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/e1dc5f1e8fe1ecdaa94ff9adcbeb681816636664

tdf#161352 - Set ChangeCase* requests as done for macro recorder

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.