Bug 161501

Summary: The new vertical tabs do not look good under kf5 (poor contrast, spacing of selection frame)
Product: LibreOffice Reporter: Rafael Lima <rafael.palma.lima>
Component: UIAssignee: Rafael Lima <rafael.palma.lima>
Status: ASSIGNED ---    
Severity: normal CC: m.weghorn, rgb.mldc, stephane.guillou
Priority: medium    
Version: 24.8.0.0 alpha1+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=144981
https://bugs.documentfoundation.org/show_bug.cgi?id=161355
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 102495, 161497    
Attachments: Screenshots comparing gtk3 and kf5
Screenshot of the proposed patch (kf5)
Screenshot with https://gerrit.libreoffice.org/c/core/+/169108 v2 with a light theme (qt6)

Description Rafael Lima 2024-06-10 23:38:55 UTC 
Created attachment 194637 [details]
Screenshots comparing gtk3 and kf5

Recently we had a change in some dialogs, that now use "vertical tabs" instead of "horizontal tabs".

TBH they look quite nice using gtk3, and in this case they feel like an improvement.

However, in kf5 they do not look good or appealing. They do not feel like an improvement. Entries seem too squeezed or compressed... and there's no good contrast for text as in gtk3.

Is there something we can do to improve the situation to render this in kf5?

See attached ODG with some examples

System info

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: dc243f0122ba656d2630e93bebfb84a2bfe4042a
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2024-06-11 04:41:09 UTC 
Reproduced in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 5a75414d1772d1fd998f405e3b9bd80b1f10c51f
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)

e.g. in Page Style dialog, characters touch the surrounding frame.
Comment 2 Rafael Lima 2024-06-18 20:44:47 UTC 
The vertical tabs are not native in kf5/gen, so I had to change how they're drawn in SvxIconChoiceCtrl_Impl.

Proposed patch here:
https://gerrit.libreoffice.org/c/core/+/169108
Comment 3 Rafael Lima 2024-06-18 22:47:31 UTC 
Created attachment 194809 [details]
Screenshot of the proposed patch (kf5)

This is a screenshot taken using kf5 after applying the proposed patch.
Comment 4 Michael Weghorn 2024-06-19 06:11:02 UTC 
Created attachment 194812 [details]
Screenshot with https://gerrit.libreoffice.org/c/core/+/169108 v2 with a light theme (qt6)