| Summary: | Config file location | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Thomas Zervogiannis <tzervo> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | detective.conan.1412, tabe, thb |
| Priority: | low | Keywords: | easyHack |
| Version: | 3.3.0 RC1 | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | a proposed fix | ||
|
Description
Thomas Zervogiannis
2010-12-09 04:32:39 UTC
Thomas, I presume you've XDG_CONFIG_HOME set? http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html does not really mandate any specific naming scheme, I admit though that in this case, leaving out the dot looks slightly nicer. Would you be interested in having a go at a fix, shouldn't be too complicated? XDG_CONFIG_HOME set here. True, apart from putting configs in XDG_CONFIG_HOME freedesktop.org does not set any more constraints but everybody uses non-dot folders after putting them in eg. .config. And ok, I will give it a shot and come back for help if needed. The XDG user directory spec does not only mandate XDG_CONFIG_HOME, but also XDG_DATA_HOME and XDG_CACHE_HOME, which could be quite interesting. See also http://ploum.frimouvy.org/?207-modify-your-application-to-use-xdg-folders for some explanation of why this is important. Created attachment 47277 [details]
a proposed fix
The attached archive contains a possible fix for this.
Please take a look at it.
(In reply to comment #4) > Created an attachment (id=47277) [details] > a proposed fix > > The attached archive contains a possible fix for this. > Please take a look at it. could you please post the patch to the dev list ( for wider audience ), but.. before doing that some minor comments about the patch a) I would use a define for "/.config" b) you should show where the magic '9' came from ( e.g. calculate it from the define ) in the code c) it seems pointless doing the first access(pStr, 0) != 0) when you really want to run access on the value of pStr + "/.config" about the change common_brand.scp hmm well I am not sure at all about that ( in the case where XDG_blah blah blah ) is not used is it so nice to have the config go into a $HOME/libreoffice instead of $HOME/libreoffice? NOTE: also this will affect windows where this XDGxxxx related directory specification does not apply Noel, thanks a lot for your comment! (In reply to comment #5) > could you please post the patch to the dev list ( for wider audience ), but.. > before doing that some minor comments about the patch > > a) I would use a define for "/.config" > b) you should show where the magic '9' came from ( e.g. calculate it from the > define ) in the code OK. > c) it seems pointless doing the first access(pStr, 0) != 0) when you really > want to run access on the value of pStr + "/.config" Sorry but I am not sure what you suggest, the first access(...) is for the path specified with XDG_CONFIG_DATA, while the second one is for HOME+"/.config", not for pStr+"/.config". > > about the change common_brand.scp hmm well I am not sure at all about that ( in > the case where XDG_blah blah blah ) is not used is it so nice to have the > config go into a $HOME/libreoffice instead of $HOME/libreoffice? > > NOTE: also this will affect windows where this XDGxxxx related directory > specification does not apply Exactly. I would like to ask that on the developer list. Seems that patches was committed. http://cgit.freedesktop.org/libreoffice/ure/commit/?id=a6f56f70a4930d3f71bd9c9b90fdd0ba20e4da5f http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=25bd2eec77ed774a37d1cddd0d72312e23d5e9fd Mark as RESOLVED/FIXED Migrating Whiteboard tags to Keywords: (EasyHack) [NinjaEdit] |