| Summary: | LibreOffice opens and reads the basis-link file ridiculously often | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Don't use this account, use tml@iki.fi <tlillqvist> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | LibreOffice |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Experimental patch | ||
|
Description
Don't use this account, use tml@iki.fi
2010-12-10 03:40:39 UTC
Unconfirmed with "LibreOffice 3.3.0 RC1 - WIN XP German UI [OOO330m17 (build 3.3.0.1)]" My LibO needs that File for startup (when I rename it, LibO can't be started), but after LibO has been launched I can rename that file in "C:\Programme\LibreOffice 3" to "basis-link_X_" and can although work without any problems. @Tor Lillqvist: What WIN? How did you check that the file has been read? Can you exclude that an Extension causes the problem? Windows XP. I see the file being opened in the debugger (or if I add debugging printouts in osl_openFile). I have a default installation, no manually added extensions. But maybe it is just hallucination. Created attachment 40993 [details] Experimental patch This seems to help, basis-link is opened only once. But that doesn't really have any immediately visible speedup effect, as I had hoped a bit. (I.e. it doesn't help bug #31716 ) The patch does a couple of things: - remove the silliness in rtl_bootstrap_args_close() where in a debugging build no cache was kept after all... I wasted half a day wondering why the data for .ini files stored in the bootstrap_map hash table wasn't found after all the next time a lookup from that same .ini file was needed, but the file had to be loaded anew. Turns out this was intentional when bootstrap.cxx was compiled with OSL_DEBUG_LEVEL > 1. I don't understand the usefulness of this, so kill it. - double the number of cached .ini files to 16. - add a second hash table called link_map where the result of reading files referenced to by .link syntax in .ini files is kept. I.e., in practice the basis-link file. This indeed helps, the basis-link file is now read only once. But as I said, that didn't have any obvious speedup effect. - drop superfluous newlines from OSL_TRACE output. OSL_TRACE by itself appends a newline. But, I don't know if it is worth it to apply this patch. I would prefer to just get rid of the basis-link and ure-link thingie completely in LibreOffice. [This is an automated message.] This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it started right out as NEW without ever being explicitly confirmed. The bug is changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases. Details on how to test the 3.5.0 beta1 can be found at: http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1 more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html @Tor Can we close this one? That depends on whether what the initial comment describes still happens or not. @Tor Exactly that was the question behind Comment 5. The whole basis/brand split got undone. So AFAIK this is now redundant. http://cgit.freedesktop.org/libreoffice/core/commit/?id=b786a33cfdca2e8a4114ddef0340e0e0628dd09c |