Bug 32897

Summary:	templates have hard-coded language
Product:	LibreOffice	Reporter:	Michael Meeks <michael.meeks>
Component:	Localization	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	critical	CC:	caolan.mcnamara
Priority:	medium
Version:	3.3.0 RC2
Hardware:	Other
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	31865
Attachments:	I reckon we can, seems to work anyway quick hack

Description Michael Meeks 2011-01-07 03:11:37 UTC

- Presentations cretaed with the wizard (or from shipped templates) now have
  wrong language / locale settings. With htis spellchecking is messed up, you
  get wrong date formats ...

We can (most likely) fix this by removing hard-coded locales from the templates themselves (hopefully triggering the default (current) locale to be used).

Comment 1 Michael Meeks 2011-01-07 03:37:00 UTC

Caolan - any ideas what to do here ? :-) can we just excise chunks from the XML in those templates ?

Comment 2 Caolán McNamara 2011-01-07 05:08:21 UTC

Created attachment 41741 [details]
I reckon we can, seems to work anyway

If I open prs-strategy I get en-US, if I then run demo.sh and reopen it I get en-IE which is nicer which I assume is what we're getting at here.

I guess this would ideally be done as part of the build in extras

Comment 3 Michael Meeks 2011-01-07 07:03:09 UTC

Whoot - looks lovely; any chance we can apply this to the files in git and just check them in again on libreoffice-3-3 ? I guess we only need to do it for:

extras/source/templates/layout/*

clearly having it in the build is more robust, but ... XSLT ? ...

and thanks ! Andre will be happy I suspect.

Comment 4 Caolán McNamara 2011-01-07 08:35:53 UTC

Created attachment 41750 [details]
quick hack

Comment 5 Caolán McNamara 2011-01-07 12:46:32 UTC

Test build here works as I would expect and seems to build under windows, pushed all this (after using mkunroll on tg_zip.mk) as...
 f25830734461140c7dd9747f1e096fefe066ba66 bootstrap 71c5b530111a2150a42439d2c3f67cf1ad943c91 extras

Not cherrypicked to 3.3 as of yet.

Comment 6 Michael Meeks 2011-01-10 01:50:00 UTC

Lovely; reviewed and pushed to libreoffice-3-3 - thanks !