| Summary: | smath does not handle accents in MathML | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Joshua Cogliati <jjcogliati-r1> |
| Component: | Formula Editor | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jjcogliati-r1, jumbo4444, l.lunak |
| Priority: | medium | ||
| Version: | 3.5.0 Beta2 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
MathML using accents.
Patch to fix most of the accent problems Mathml using accents Patch to fix all simple accent problems |
||
|
Description
Joshua Cogliati
2011-02-02 12:08:09 UTC
Reproduce with LibO 3.4.2 on WinXP [This is an automated message.] This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it started right out as NEW without ever being explicitly confirmed. The bug is changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases. Details on how to test the 3.5.0 beta1 can be found at: http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1 more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html Hello, I can confirm bug on LibO 3.5b2 on WinXP. Created attachment 54976 [details]
Patch to fix most of the accent problems
Adds the needed cases to CreateTextFromNode to accent related problems with importing from mathml such as vectors and hat accents.
Created attachment 55079 [details]
Mathml using accents
Attachment that uses all the regular sized accents.
Right now, the patch works adds support for all libre office regular sized accents except for dddot, which libre office outputs as 0x20DB, but expects as 0xE09B. I this could be fixed by changing the patch to add something like:
0xE09B is in the private use area of unicode.
case 0xE09B:
+ case 0x20DB:
APPEND(rText,"dddot ");
break;
Created attachment 55147 [details]
Patch to fix all simple accent problems
Adds the needed cases to CreateTextFromNode to fix accent related problems with
importing from mathml such as vectors and hat accents.
Compared to the previous patch, this fixes dddot. This patch also adds comments that tell which unicode character is being matched.
Now all the following can be read from a mathml file:
acute a grave b check c breve d circle e vec f tilde g hat h bar i dot j ddot k
dddot l
I believe this patch is done, and I request that it be considered for inclusion in 3.5
looks sane, committed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=b90ac7d682fd65f75eff4225d871130c0ae9f185 caolanm->Joshua: can you add yourself to http://wiki.documentfoundation.org/Development/Developers and send to the list (like the examples there) a statement that the patch is under our preferred LGPLv3+/MPLv1.1 caolanm->llunak: you're closest to the import mathml in ooxml stuff, does this change help that out ? and/or worth cherry-picking for 3-5 ? This fix is irrelevant for ooxml, I made it do the necessary conversions already on import. I guess this makes sense, also for 3-5. Comparing it to my import code, I see there are widehat and widevec missing in this list, and there are symbolic constants for the hexa values. I'll change this and push to 3-5 too. Ignore the second paragraph, I got it backwards. I'll just backport as it is and use the symbolic contants in master. Sounds good. FYI the patch I wrote can be used with LGPLv3+/MPLv1.1. |