| Summary: | Find Toolbar won't close if left open | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Zack <zcreveling> |
| Component: | UI | Assignee: | Jan Holesovsky <kendy> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | minor | CC: | cno, courrier.oou.fr.mjk, jorendc, LibreOffice, zcreveling |
| Priority: | medium | ||
| Version: | 3.4.0 Beta2 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
How toolbar looks open
Toolbar closed with ugly bar left |
||
|
Description
Zack
2011-04-20 15:57:56 UTC
Created attachment 45879 [details]
How toolbar looks open
This screenshot is of the new Find toolbar and how it looks open. The dropdown is expanded and I'm about to click Close Toolbar. The next screenshot shows what is left after closing the toolbar.
Created attachment 45880 [details]
Toolbar closed with ugly bar left
This is how the Find toolbar looks after it has been closed using the button (the only way to 'close' it if the toolbar was left open). As you can see, the contents disappear, but the bar remains. I circled the bar in Red.
Looking at the 3.4 release notes it looks like you helped in creating this improvement. Mind taking a look Jan? [Zack] "This is how the Find toolbar looks after it has been closed using the button (the only way to 'close' it if the toolbar was left open). As you can see, the contents disappear, but the bar remains." Setting the focus (cursor) into the "find toolbar" will close "the whole thingy" with Esc, as expected. INVALID? (In reply to comment #4) > [Zack] > "This is how the Find toolbar looks after it has been closed using the button > (the only way to 'close' it if the toolbar was left open). As you can see, the > contents disappear, but the bar remains." > > Setting the focus (cursor) into the "find toolbar" will close "the whole > thingy" with Esc, as expected. > > INVALID? Ok if I click the find text box after the toolbar has been left open you're right, clicking escape will then close the toolbar. But I don't think the toolbar should be left open between closing the program and reopening. Firefox does not behave this way (which is what this feature is modeled after) and neither does Chrome. Clicking 'close toolbar' does not close the toolbar either, which is certainly a bug. Yep, I agree with this point of view. I have misunderstood your issue, my mistake, sorry. Changing component to Libreoffice as this affects all the components of LO, not just writer. Compared to the other toolbar problems, especially Bug 36571 - Find bar does not appear properly at top of screen This is a minor one, I don't see it as a "most annoying one". Removed from "Most Annoying". @Kohei: Can you please check? There is a duplicate for this filed somewhere. And I remember I assigned the original bug to kendy. I'll do the same for this one. Should we also be considering adding a X button to the find toolbar? The find toolbar is modeled after Firefox and Chrome and both of those browsers display a graphical close button in the toolbar. Pressing the 'Esc' key is not really discoverabl, I only found out about that shortcut when reading this bug report. IMO shortcut keys should only ever act as a secondary method of doing something, and not the primary method. Hi Joren, * IN 4.0.0RC1 - Writer - Ctrl-F - Click in Document - Close LibreOffice - Restart - Writer document - Ctrl+F (focus in Find bar) - Esc >> Find bar closes... So looks OK, anyway on my Linux Ubuntu 12.10 32 bits (In reply to comment #13) > Hi Joren, * > IN 4.0.0RC1 > - Writer > - Ctrl-F > - Click in Document > - Close LibreOffice > - Restart > - Writer document > - Ctrl+F (focus in Find bar) > - Esc >> Find bar closes... > So looks OK, anyway on my Linux Ubuntu 12.10 32 bits I agree with that, and Bug 58526 and Bug 59101 this'll be fixed (you also can use ctrl+F to toggle). Tested with ubuntu 12.10 x64; Can't reproduce bug anymore -> RESOLVED WORKSFORME |