| Summary: | Calc systematically aborts when trying to sort on two columns | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Helmut Leininger <hlein> |
| Component: | Calc | Assignee: | Kohei Yoshida <kohei> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | LibreOffice, vitriol_vitriol |
| Priority: | medium | ||
| Version: | 3.4.0 Beta3 | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:3.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Spreadsheet which produces the error
Spreadsheet that shows the problem |
||
Calc also aborts when trying to sort other sheets, also sortin onlyone column Assigned to me Is related to the new sheet local anonymous db data SIGSEGV in GetAnonymousDBData() @Helmut: Can you save the Spreadsheet and reopen it after closing Calc? Calc automatically saves the spreadsheet when it aborts. I can reopen it - LibO executes the recovery. I can make modifications to the document, no preoblem. But when I try to sort, it aborts. Once, after some changes, I could sort one sheet, but since the next time, it aborts again. No problem sorting the same spreadsheet with LibO 3.3.2 Regards Remark: The problem occurs also in OpenOffice 3.4 beta. Can you give some additional information when this happens? I think you installed de language pack? At least with your information that OO3.4 beta crashes too, I can't reproduce this problem. Created attachment 46247 [details]
Spreadsheet that shows the problem
OOO: I have the German language pack installed. The slight difference in the behaviour of OOO and LibO is that OOO restarts aautomatically (LibO must be restarted manually) and it gathers some information that is sent to Oracle. I made another test after de-installing the language pack - Calc keeps aborting. The attachment id=46247 (Comment 6, second of the attachments) shows the problem, trying to sort "Grinzing" by "Sortierung" and "Name" [Reproducible] with "LibreOffice 3.4Beta3 – WIN7 Home Premium (64bit) German UI [DEV300m103 (Build:3)]" Steps to reproduce: 1. Select columns A,B by clicking Column Heading 'A' and then dragging Mouse pointer with pushed left mouse button to Heading 'B' 2. Menu 'Data > Sort > A=ascending, B= ascending Libo crashes Attention, it might be that that crash will destroy your LibO, I lost ability to open 1 particular spreadsheet what I had used until that test without problems. Modified Status due to facts. Per our email conversation, I'll take a look at this. Something must have changed in the undo manager in OOo code, which we inherited. That one is causing the undo object to get deleted as soon as it is added, which causes the crash. This http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4&id=d53ec5342f018f7c766e47bf67aefebd3fe76d6a fixes it. Prior to the change in SfxUndoManager, the undo manager was either enabled or disabled. After the change, however, SfxUndoManager keeps track of the number of times EnableUndo(true) and EnableUndo(false) have been called, so if you call EnableUndo(false) 10 times, you need to call EnableUndo(true) the same amount of times in order to get it re-enabled. In Calc, unfortunately we tend to call EnableUndo(false) so many times, just to be safe, and expect it to get re-enabled by calling EnableUndo(true) just once. This assumption no longer holds true, and as this report demonstrates it sometimes causes crashes. Anyway, this should now be fixed in the 3.4 branch. |
Created attachment 46226 [details] Spreadsheet which produces the error calc always aborts when I try to sort the sheet Grinzing of the attached document on Name and Ref. (Daten - Sortieren - Name and Ref , ascending) Windows XP Sp3, LibreOffice 3.4 Beta 3