| Summary: | testtool complains Unknown Command for legal script when running bas. | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yifan Jiang <yfjiang> |
| Component: | BASIC | Assignee: | Noel Power <nopower> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | matuaki |
| Priority: | medium | Keywords: | regression |
| Version: | 3.4.0 Beta5 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | patch for 3.4 | ||
Hi Noel, since this is constantly reproducible in a clean environment. I opened the bug for your review. Thanks! P.S It might also influence other 'internal command' of testautomation thus make the automation test not runnable. Hmmm, I just left a comment on the dev mailing list about the smoketests failing during make check when building from master ? Something to do with failed assertions in officeconnection.cxx - linked ? Alex Created attachment 51392 [details]
patch for 3.4
fixes ( or appears to ) fix the testtool problems on 3.4
I tested with f_topten.bas ( because it is a short test ) Note: I started running the one mentioned above but after some time it was clear this test was going to take too long so I tried f_topten.bas instead.
The root cause of the problems was cws changehid which replaced numerical hid's by strings. Additionally the class smarthid was removed.
The patch imo is not ideal, . It appears that there are still hid(s) that are stringified numbers ( or at least that's what the testtool code expects ) and now the testtool code goes to extra trouble to convert between strings/numbers. I would guess this makes the testtool slower. This should be changed on master, for 3.4 I think a "just get it working" approach might be the best
fixed on 3.4 branch |
Platform: SLED 11 sp1 i586 build info: Libreoffice 3.4 beta5 [Steps] 1. Install LibO 3.4 beta5 as well as testtool package 2. Run f_basic_first.bas using: /opt/libreoffice3.4/basis-link/program/testtool.bin -run $TESTAUTOMATION/framework/optional/f_basic_first.bas [Problem] When the testtool step through the ResetApplication in master.inc, it complains an error : Unknown command '' [Extra Information] - I reproduced the problem in 2 platforms, so pretty sure it was something wrong there. - Regression problem against 3.3