Bug 37808

Summary: Button 'Word Justify' works incorrectly on fontwork
Product: LibreOffice Reporter: ape <idler.1st>
Component: UIAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: neutr, rb.henschel, sasha.libreoffice
Priority: medium    
Version: Inherited From OOo   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107634    
Attachments: Error work 'Word Justify'-button
Extected work 'Word Justify'-button
Work 'Left Align'-button
test case

Description ape 2011-06-01 01:09:35 UTC
Created attachment 47410 [details]
Error work 'Word Justify'-button

OS - Windows_XP_64bit (All_OS); LibreOffice-3.4,3.3.2(Writer, Calc, Web, Draw, Impress); the Pop-up window 'Fontwork Alignment', toolbar 'Fontwork'.
Button 'Word Justify' works incorrectly. It repeats actions of button 'Left Align'. Expected actions of button 'Word Justify' are shown in figure.
Comment 1 ape 2011-06-01 01:12:15 UTC
Created attachment 47411 [details]
Extected work 'Word Justify'-button
Comment 2 ape 2011-06-01 01:16:05 UTC
Created attachment 47412 [details]
Work 'Left Align'-button
Comment 3 ape 2011-06-01 01:20:53 UTC
(In reply to comment #1)
> Created an attachment (id=47411) [details]
> Extected work 'Word Justify'-button
Sorry: Expected work 'Word Justify'-button
Comment 4 Björn Michaelsen 2011-12-23 12:03:40 UTC Comment hidden (obsolete)
Comment 5 sasha.libreoffice 2012-01-25 23:11:07 UTC
Created attachment 56166 [details]
test case

reproduced in LibO 3.6.0 master on Fedora 64 bit
Comment 6 ape 2013-12-22 13:46:49 UTC
Reproduced in LibO 4.3.0.0+ (master)
Comment 7 Joel Madero 2015-05-02 15:42:17 UTC Comment hidden (obsolete)
Comment 8 ape 2016-04-25 12:50:17 UTC
I confirm this bug:
LibO version: 5.2.0.0.alpha1; Build ID: 902b28a39528b6c92602e9b521a1d0861be1caf9
OS Version: Windows 5.2 x64
Comment 9 QA Administrators 2018-05-06 02:30:16 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2020-05-06 03:44:12 UTC Comment hidden (obsolete)
Comment 11 Julien Nabet 2020-09-08 14:42:13 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Here's a codepointer:
https://opengrok.libreoffice.org/xref/core/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx?r=e67657d5#540

case SDRTEXTHORZADJUST_BLOCK : break;   // don't know
case SDRTEXTHORZADJUST_LEFT : break;    // already left aligned -> nothing to do
Comment 12 Regina Henschel 2021-10-07 23:49:07 UTC
The current rendering is wrong, the text should be centered.

The option "Word justify" is currently bound to the setting "option middle/center with checked 'Full width'" in the 'Text Attributes' dialog. That means, that it specifies an anchor for the text block. [The options 'Left align', 'Right align' and 'Center' are too bound the Anchor setting in the 'Text Attributes' dialog.]

The setting 'Full width' means, that the reference for the alignment of paragraphs in the text block of a custom shape is the edge of the text area of the custom shape. 'Full width disabled' means, that the reference is the box of the longest paragraph. But that makes no sense for Fontwork. The paragraphs in the text of a Fontwork cannot have different alignments and the text area is ignored for Fontwork.

This bounding to the "Text Attributes" dialog exists already in OOo2.4.3. and also the error, that the text becomes left aligned.

The expected behavior of "justify" cannot be achieved with binding to anchor "middle/center with 'full width' checked". So either the option should be removed or a new implementation is needed.
Comment 13 Regina Henschel 2022-11-04 17:37:48 UTC
This button no longer exists in Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 17dfc9a9da009cc23d2222e3fb4e2cef9c97d581
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

So this bug report is obsolete. Such term is not in the status list. Therefore I use "WORKSFORME".