Bug 38828

Summary: Save position of tab dialogs
Product: LibreOffice Reporter: Björn Michaelsen <bjoern.michaelsen>
Component: UIAssignee: Travis Carter <bugs>
Status: RESOLVED FIXED    
Severity: enhancement CC: dwayne, kendy, robinson.libreoffice
Priority: medium Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: Fixes dialog location and current page not being stored properly

Description Björn Michaelsen 2011-06-30 08:50:54 UTC 
Background: SfxTabDialog::~SfxTabDialog() idealls saves the position of the dialogs according to this comment. However, in practice this is not really true: edit a style in Writer, move the dialog, press the apply button, and the position is reset. It would be nice to really save the position.

Skills: building, C++
Comment 1 Florian Reisinger 2012-05-18 09:49:15 UTC 
Deleted "Easyhack" from summary.
Comment 2 Efe Gürkan YALAMAN 2012-06-11 12:04:39 UTC 
I think this bug does not exist anymore .
Comment 3 Björn Michaelsen 2012-06-11 13:07:47 UTC 
@Kendy: Did you originally file this one? Can we close it as WORKSFORME?
Comment 4 Travis Carter 2012-06-21 17:34:56 UTC 
Created attachment 63328 [details]
Fixes dialog location and current page not being stored properly

Hopefully, this is an appropriate patch for this bug. Dialogs should now appear in their previous location after clicking Apply or Ok and then reopening them. Furthermore, clicking Apply should now keep focus on the current tab-page instead of reverting back to the initial one (this wasn't an issue listed in the initial bug post, but it was happening to me in multiple versions and related so the fix is there.)
Comment 5 Dwayne Bailey 2012-06-22 00:43:07 UTC 
*** Bug 50534 has been marked as a duplicate of this bug. ***
Comment 6 Dwayne Bailey 2012-06-22 00:44:17 UTC 
I marked bug 38828 as a duplicate of this.  Although my report related to reseting, I suspect that this patch might solve the issue.  I can't confirm, would appreciate if those that hacked the fix (many thanks) could validate that what I observed is in fact fixed.
Comment 7 Dwayne Bailey 2012-06-22 00:45:03 UTC 
Sorry got the number wrong I meant 50534 is a duplicate of this bug
Comment 8 Travis Carter 2012-06-22 04:04:12 UTC 
I can confirm that it fixes bug 50534.
Comment 9 Caolán McNamara 2012-06-27 09:03:07 UTC 
patch got committed to master for 3-7 to fix this
Comment 10 Robinson Tryon (qubit) 2015-12-16 00:11:48 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicUi)
[NinjaEdit]