Bug 39849

Summary:	exchange SfxItemset implementation
Product:	LibreOffice	Reporter:	Björn Michaelsen <bjoern.michaelsen>
Component:	LibreOffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	arnaud.versini, maciej.rumianowski, p.weissenbacher, robinson.libreoffice
Priority:	medium	Keywords:	difficultyInteresting, easyHack, skillCpp, skillTest
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:	34465
Bug Blocks:

Description Björn Michaelsen 2011-08-05 00:22:38 UTC

I tried a clean new from the group up reimplementation of
SfxItemset once in cws new_itemsets:

 http://hg.services.openoffice.org/cws/new_itemsets/file/924a55dab4dc/svl/inc/svl/itemset.hxx
 http://hg.services.openoffice.org/cws/new_itemsets/file/924a55dab4dc/svl/source/items/itemset.cxx

the intention was to be able to optimize on the code (with seemed to be
impossible with the bit-rotten old one) as SfxItemsets pose a major
part of the load/save-instructions. I never got to integrate that cws,
as its performance currently is just on par with the old implementation
(IIRC, ~8% faster on Linux, but a bit slower on Windows). I still
think it would be a much better base for optimization and finetuning
than the current codebase, let alone be more readable (for example it
is doing the same thing in half the LOC).

Comment 1 Sebastian@SSpaeth.de 2012-05-15 00:01:25 UTC

Just to highlight the relevance of this bug.

Bug #38513 demonstrates that abysmal SfxItemSet performance contributes to 10 minutes loading time and 1h saving time for a 2mb .odt file containing lots of style switches.

Not sure if the other bug should depend on this one or vice versa.

Comment 2 Florian Reisinger 2012-05-18 09:11:18 UTC

Deteted "Easyhack" from summary

Comment 3 Arnaud Versini 2013-09-01 19:28:07 UTC

@Bjorn for information, access to CWS seems unavaible for now, do you have a copy of the repository ?

Comment 4 Björn Michaelsen 2013-10-04 18:46:18 UTC

adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details

Comment 5 Tobias Lippert 2015-05-24 11:44:23 UTC

Hello Björn,
unfortunately, your mercurial links are not working anymore. Do you happen to have a backup copy of the files? Maybe you can attach them to this ticket.
Tobias

Comment 6 Robinson Tryon (qubit) 2015-12-14 06:58:33 UTC

Migrating Whiteboard tags to Keywords: (EasyHack DifficultyInteresting SkillCpp SkillTest)
[NinjaEdit]

Comment 7 Björn Michaelsen 2016-01-26 12:59:57 UTC

Closing this one as WONTFIX -- too much happened in the meantime, this would need a reevaluation and reimplementation from scratch -- and that isnt an easyHack.

Comment 8 Robinson Tryon (qubit) 2016-02-18 16:37:05 UTC

Remove LibreOffice Dev List from CC on EasyHacks
(curtailing excessive email to list)
[NinjaEdit]