Bug 41474

Summary: EasyHack: obsolete rtl::O[U]StringBuffer::{charAt,setCharAt}
Product: LibreOffice Reporter: Stephan Bergmann <sberg.fun>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal Keywords: easyHack
Priority: medium    
Version: Master old -3.6   
Hardware: Other   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:

Description Stephan Bergmann 2011-10-05 05:32:51 UTC 
With <http://cgit.freedesktop.org/libreoffice/core/commit/?id=112bdf84d684590e042725c7173e059b4afa2f83> "Removed dangerous rtl::O[U]String[Buffer]::operator sal_{char,Unicode} const *." the member functions

rtl::OStringBuffer::charAt
rtl::OStringBuffer::setCharAt
rtl::OUStringBuffer::charAt
rtl::OUStringBuffer::setCharAt

(that followed a misguided inspiration from Java's StringBuffer) are obsolete.  They should be marked as SAL_DEPRECATED and their uses be replaced with uses of operator [].
Comment 1 August Sodora 2011-12-01 13:24:09 UTC 
Just finished removing these on master
Comment 2 Robinson Tryon (qubit) 2015-12-18 10:02:46 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack)
[NinjaEdit]