Bug 42924

Summary:	errors in the display of the sample arrays as rendered in wikiHelp
Product:	LibreOffice	Reporter:	David <dcramptond>
Component:	Documentation	Assignee:	Korrawit Pruegsanusak <detective.conan.1412>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kendy
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:

Description David 2011-11-14 08:00:13 UTC

As I originally posted in the Users forum:

At page: http://help.libreoffice.org/Calc/Array_Functions there are errors
in the display of the sample arrays. The text of the example is correct
but the error in the example array makes the "explanation" less
effective... putting it kindly.

The top row of each array should have its content shifted right by one
cell. The top-leftmost cell in the example should be empty. The top row
and left column are intending to display, respectively, the column numbers
and row numbers.

The errors are the same for all the example arrays and also in at least
several of the languages.

The login to 'help.libreoffice.org' is apparently different than
'www.libreoffice.og'. I don't want to create so many different
credentials. How, then, to report this error? If not sufficiently done
here.
-- 
David S. Crampton
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The following thread further documents the issue and encourages me to post here to Bugzilla:

Hi Korrawit, Davide

Sorry for the late answer 

Korrawit - thank you for the forward!

David - the best for all the bug reports is the Bugzilla:

https://bugs.freedesktop.org

Korrawit is right that it is an issue with the tooling that converts the
help to the wiki syntax.  I'll have a look; unfortunately cannot have a
look just immediately   But incidentally - if you have experience
with Python, you may improve it yourself, and send a patch; if you send
me a fix, I can re-run the conversion of those pages immediately.

The sources are here:

http://cgit.freedesktop.org/libreoffice/help/tree/helpcontent2/to-wiki/wikiconv2.py

[you need to clone the entire
http://cgit.freedesktop.org/libreoffice/help, though]

Tables are handled between line numbers 475 and 526.  If you are
interested, and have more questions, please just ask, or reach me on the
IRC: irc.freenode.net, channel #libreofffice-dev, nick 'kendy'.

Thank you a lot,
Kendy

On 2011-11-08 at 11:08 +0700, Korrawit Pruegsanusak wrote:
> Hello Jan,
>  
> Regarding forwarded message below, LOCALHELP looks fine, so IMHO maybe
> some issue with the conversion to wiki syntax. Could you please have a
> look? Thanks.
>  
> Best Regards,
>  
> ---------- Forwarded message ----------
> From: webmaster for Kracked Press Productions <webmaster@krackedpress.com>
> Date: Mon, Nov 7, 2011 at 22:45
> Subject: [libreoffice-website] Fwd: [libreoffice-users] How do I
> report an error in Help web pages?
> To: LibreO - Website <website@global.libreoffice.org>
>  
>  
>  
> I think  this message need to be listed here, so I forwarded it and
> told the user I would do so.
>  
> -------- Original Message --------
> Subject:        [libreoffice-users] How do I report an error in Help web pages?
> Date:   Mon, 07 Nov 2011 07:16:30 -0800
> From:   David S. Crampton <david_crampton@ie2b.com>
> Reply-To:       users@global.libreoffice.org
> Organization:   That Is 2 Be Engineering Services
> To:     Users discussions at global.libreoffice.org
> <users@global.libreoffice.org>
>  
>  
>  
> At page: http://help.libreoffice.org/Calc/Array_Functions there are errors
> in the display of the sample arrays. The text of the example is correct
> but the error in the example array makes the "explanation" less
> effective... putting it kindly. <snip, see above>

Comment 1 Korrawit Pruegsanusak 2011-11-20 08:06:49 UTC

I'm taking a look at this.

Comment 2 Andras Timar 2011-11-22 09:57:46 UTC

(In reply to comment #1)
> I'm taking a look at this.

The problem is that the wikiconv2.py script does not handle empty table cells. It expects something to be in the table cell: a paragraph, a section etc.

There are 146 empty table cells in help (<tablecell></tablecell>). Either the script should be fixed, or these 146 empty cells should be filled with something (a space character for example).

Comment 3 Korrawit Pruegsanusak 2011-11-22 19:39:44 UTC

(In reply to comment #2)
> The problem is that the wikiconv2.py script does not handle empty table cells.
> It expects something to be in the table cell: a paragraph, a section etc.

Yes, Thanks!

> There are 146 empty table cells in help (<tablecell></tablecell>). Either the
> script should be fixed, or these 146 empty cells should be filled with
> something (a space character for example).

A space character isn't enough, because the script expects some child element.
Currently I'm trying to place a check whether the tablecell element is empty, but no success yet.

Comment 4 Korrawit Pruegsanusak 2011-12-09 19:31:55 UTC

Patch pushed at http://cgit.freedesktop.org/libreoffice/help/commit/?id=d1db994e9fd850ef4163921efde7804f2b074520

Jan will trigger an update to wikihelp "shortly after Beta 1". See http://lists.freedesktop.org/archives/libreoffice/2011-December/021904.html