Bug 46258

Summary:	EasyHack: remove obsolete 'isTestTool' from vcl ...
Product:	LibreOffice	Reporter:	Michael Meeks <michael.meeks>
Component:	LibreOffice	Assignee:	Josh Heidenreich <josh.sickmate>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	difficultyBeginner, easyHack, skillCpp, topicCleanup
Priority:	medium
Version:	Master old -3.6
Hardware:	Other
OS:	All
Whiteboard:	target:3.6.0
Crash report or crash signature:		Regression By:
Attachments:	Removal of the code.

Description Michael Meeks 2012-02-18 11:44:09 UTC

VCL used to have code to adapt to the presence of the test-tool that it used to run under. This is now gone forever, so we should strip it out:

git grep mbIsTestTool

and rip/replace all it's dependents - it should be always false.

Thanks :-)

Comment 1 Josh Heidenreich 2012-02-20 18:38:10 UTC

Created attachment 57370 [details]
Removal of the code.

I'm fairly sure this is all good, but was hoping someone would be able to check before I push.

Comment 2 Michael Meeks 2012-02-21 04:06:55 UTC

Looks lovely to me :-) please do push & close - thanks ! :-)

Comment 3 Josh Heidenreich 2012-02-21 14:41:39 UTC

Pushed.

Comment 4 Not Assigned 2012-02-21 14:45:16 UTC

Josh Heidenreich committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=936ebcfa4b44a90bdc8789ce7556f1ba3599375c

EasyHack fdo#46258 Removal of VCL testtool support (-enableautomation option)

Comment 5 Robinson Tryon (qubit) 2015-12-15 23:49:35 UTC

Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]