Bug 46399

Summary:	EasyHack: vcl - cleanup empty methods ...
Product:	LibreOffice	Reporter:	Michael Meeks <michael.meeks>
Component:	LibreOffice	Assignee:	Greggory Hernandez <greggory.hz>
Status:	RESOLVED FIXED
Severity:	normal	CC:	greggory.hz
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillCpp, topicCleanup
Version:	Master old -3.6
Hardware:	Other
OS:	All
Whiteboard:	target:3.6.0
Crash report or crash signature:		Regression By:
Attachments:	Consolidate empty methods

Description Michael Meeks 2012-02-21 08:13:29 UTC

The vcl/inc/salobj.hxx interface is implemented by several platform backends but many of these use the same (empty) implementations for several of the methods eg.

'GrabFocus', 'SetBackround', and 'Enable'

it'd be great to have an empty default in the parent implementation instead, and remove all those dummy overrides in the headers and implementations.

It is possible that a few similar cases exist for other backend classes too.

Thanks :-)

Comment 1 Greggory Hernandez 2012-02-21 19:54:57 UTC

Created attachment 57430 [details]
Consolidate empty methods

I've sent this to the mailing list as well.

Comment 2 Michael Meeks 2012-02-22 01:41:59 UTC

thanks ! :-)

Comment 3 Not Assigned 2012-02-22 01:43:05 UTC

Greggory Hernandez committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cf3d1d6a18af079f8afd0b18be5b15b043948e

vcl: fdo#46399 cleanup and share dummy virtual methods ...

Comment 4 Robinson Tryon (qubit) 2015-12-15 23:49:34 UTC

Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]