| Summary: | resource compiler produces English .res files for any language | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Andras Timar <timar74> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, cno, l.lunak, sberg.fun |
| Priority: | medium | ||
| Version: | Master old -3.6 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:3.6.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Andras Timar
2012-03-31 12:17:25 UTC
hmm, git-bisect in progress odd, http://cgit.freedesktop.org/libreoffice/core/commit/?id=53fb5f774e262e6dbe364c9da06ae5e0db11b5d7 triggers it somehow aha http://opengrok.libreoffice.org/xref/core/i18npool/inc/i18npool/mslangid.hxx#236 sal_Char maLangStr[4]; Well, for the immediate problem http://cgit.freedesktop.org/libreoffice/core/commit/?id=791f27683311e487947b0464a0cb132b19fd0e12 will fix it, but I guess more problems like this could lurk around the place. Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=791f27683311e487947b0464a0cb132b19fd0e12 Resolves: fdo#48129 maLangStr can have trailing nulls IIRC there was initially a check for embedded \0's in string literals and then I removed it later, arguing that if the literal contains it, it's wanted, but seeing this I'll put the check back again and clean up any valid embedded \0 usage. *** Bug 47530 has been marked as a duplicate of this bug. *** I added Fix submitter as assignee because this will ease queries and bug tracking. |