Bug 49601

Summary: Replace home-grown regexp parser with some std library
Product: LibreOffice Reporter: Sergey <fuxx>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:

Description Sergey 2012-05-07 12:41:12 UTC
From here: http://wiki.documentfoundation.org/Development/Crazy_Ideas:

Idea: Currently libs-gui/regexp contains a home-grown regexp-parser. Not only is this in libs-gui in the wrong location, but these standard tasks should be done by some external library specialized for that purpose, such as libregex, pcre, regex from boost (or whatever). Investigate this usage and rip it out, replacing calls to some standard library.
Actually this http://opengrok.go-oo.org/xref/libs-gui/i18npool/source/search/textsearch.cxx#34 seems like the only occurence where we import the regexp, so removing that one might actually be quite easy. Other parts or the code already import #include <unicode/regex.h> and standard #include <regex.h> so we would not be introducing new requirements anyway.
Comments: A regex library, or regex functions in the C library, is "standard" only on many Unix platforms, though. For a generic Linux build, and for Windows, we still need a regex library in-tree.
Comment 1 Michael Meeks 2012-12-18 16:20:33 UTC
Thanks for the input - we re-based on the Apache code which switched regexp to use the underlying ICU engine - which hopefully is a simplification, fixes several bugs and meets this requirement :-)