Bug 51357

Created attachment 64460 [details]
Support for the checkerboard transition effect

The checkerboard transition effect was implemented following the steps in this easyhack. Check the attachment for the effect. The code can be viewed at http://cgit.freedesktop.org/libreoffice/core/commit/?id=6ee666c53da83982784ea59894479a8b93c8ecd7 .

adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details

Hello, I'm going to add the support for the Iriswipe-Transitionl.

Hello,
I have a problem with the export. In the exported svg-file there is no javascript integrated. So i can't test anything. Are there any special parameters for the autogen.sh to set? What else can be the reason for my problem?
Thanks for helping me.

I'm sorry, but I can't do the IrisWipe-Transition anymore, because I get some kernel rejected CS messages when using the IrisWipe. So it's still left to be implemented.

Hello, I would like to work on this issue,
I have few doubts about the first task

>Near to some type or subtype constant you can see a number commented out that >number is the value of the constant in the C++ file, please keep such constants in >the correct order.

What do you mean by *correct order*?Could you please brief it.

>You need to update aTransitionTypeInMap, aTransitionTypeOutMap,  >aTransitionSubtypeInMap and aTransitionSubtypeOutMap accordingly.

Moreover I can't find aTransitionSubtypeOutMap and aTransitionTypeOutMap in https://cgit.freedesktop.org/libreoffice/core/tree/filter/source/svg/presentation_engine.js

*** Bug 144785 has been marked as a duplicate of this bug. ***

Just a quick question the 'miscDiagonalWipe' is not present in the sd/xml/effects.xml 

but it's present int the filter/source/svg/presentation_engine.js

  'miscDiagonalWipe'  : MISCDIAGONALWIPE_TRANSITION,
var MISCDIAGONALWIPE_TRANSITION     = 24; // 7


same for the    

 'pushWipe'          : PUSHWIPE_TRANSITION,



but, as given in point 2 they are present in the -

TransitionType.idl and TransitionSubType.idl

So, I just want to clarify that do I have add same in the effects.xml ?

(In reply to Devansh Varshney from comment #13)
> Just a quick question the 'miscDiagonalWipe' is not present in the
> sd/xml/effects.xml 
> 
> but it's present int the filter/source/svg/presentation_engine.js
> 
>   'miscDiagonalWipe'  : MISCDIAGONALWIPE_TRANSITION,
> var MISCDIAGONALWIPE_TRANSITION     = 24; // 7
> 
> 
> same for the    
> 
>  'pushWipe'          : PUSHWIPE_TRANSITION,
> 
> 
> 
> but, as given in point 2 they are present in the -
> 
> TransitionType.idl and TransitionSubType.idl
> 
> So, I just want to clarify that do I have add same in the effects.xml ?

One more question -

I am adding the support for the triangleWipe -

In the offapi/com/sun/star/animations/TransitionSubType.idl there are already variables which are assigned the value as described on the w3.org -

"triangleWipe" 	"up" (103) [default], "right" (104), "down" (105), "left" (106) 


    const short FADEFROMCOLOR = 103;
    const short FADEOVERCOLOR = 104;

    // Most of those below are non-standard, not in SMIL 2.0
    const short THREEBLADE = 105;
    const short EIGHTBLADE = 106;
    const short ONEBLADE = 107;
    const short ACROSS = 108;
    const short TOPLEFTVERTICAL = 109; // Is in SMIL
    const short COMBHORIZONTAL = 110;
    const short COMBVERTICAL = 111;
    const short IN = 112; // Not actually a subtype, and apparently unused
    const short OUT = 113; // Ditto
    const short ROTATEIN = 114;
    const short ROTATEOUT = 115;
    const short FROMTOPLEFT = 116;
    const short FROMTOPRIGHT = 117;
    const short FROMBOTTOMLEFT = 118;
    const short FROMBOTTOMRIGHT = 119;

    // Below are for the triangleWipe
    const short TRIANGLEWIPE_UP = 103;
    const short TRIANGLEWIPE_RIGHT = 104;
    const short TRIANGLEWIPE_DOWN = 105;
    const short TRIANGLEWIPE_LEFT = 106; 



So should I do this ?- 

    // Below are for the triangleWipe
    const short TRIANGLEWIPE_UP = 120;    //103
    const short TRIANGLEWIPE_RIGHT = 121; //104
    const short TRIANGLEWIPE_DOWN = 122;  //105
    const short TRIANGLEWIPE_LEFT = 123;  //106

Or instead of adding new subtypes should I use the - 

    'up'                            : UP_TRANS_SUBTYPE,
    'right'                         : RIGHT_TRANS_SUBTYPE,
    'bottom'                        : BOTTOM_TRANS_SUBTYPE,
    'left'                          : LEFT_TRANS_SUBTYPE,

Currently I have added these -

    'triangleWipeUp'                : TRIANGLEWIPE_UP_SUBTYPE,
    'triangleWipeRight'             : TRIANGLEWIPE_RIGHT_SUBTYPE,
    'triangleWipeDown'              : TRIANGLEWIPE_DOWN_SUBTYPE,
    'triangleWipeLeft'              : TRIANGLEWIPE_LEFT_SUBTYPE
};


aTransitionInfoTable[TRIANGLEWIPE_TRANSITION] = {};
aTransitionInfoTable[TRIANGLEWIPE_TRANSITION][TRIANGLEWIPE_UP_SUBTYPE] = {
    'class': TRANSITION_CLIP_POLYPOLYGON,
    'rotationAngle': 0.0,
    'scaleX': 1.0,
    'scaleY': 1.0,
    'reverseMethod': REVERSEMETHOD_SUBTRACT_AND_INVERT,
    'outInvertsSweep': true,
    'scaleIsotropically': false
};

aTransitionInfoTable[TRIANGLEWIPE_TRANSITION][TRIANGLEWIPE_RIGHT_SUBTYPE] = {
    'class': TRANSITION_CLIP_POLYPOLYGON,
    'rotationAngle': 90.0,
    'scaleX': 1.0,
    'scaleY': 1.0,
    'reverseMethod': REVERSEMETHOD_SUBTRACT_AND_INVERT,
    'outInvertsSweep': true,
    'scaleIsotropically': false
};

aTransitionInfoTable[TRIANGLEWIPE_TRANSITION][TRIANGLEWIPE_DOWN_SUBTYPE] = {
    'class': TRANSITION_CLIP_POLYPOLYGON,
    'rotationAngle': 180.0,
    'scaleX': 1.0,
    'scaleY': 1.0,
    'reverseMethod': REVERSEMETHOD_SUBTRACT_AND_INVERT,
    'outInvertsSweep': true,
    'scaleIsotropically': false
};

aTransitionInfoTable[TRIANGLEWIPE_TRANSITION][TRIANGLEWIPE_LEFT_SUBTYPE] = {
    'class': TRANSITION_CLIP_POLYPOLYGON,
    'rotationAngle': 270.0,
    'scaleX': 1.0,
    'scaleY': 1.0,
    'reverseMethod': REVERSEMETHOD_SUBTRACT_AND_INVERT,
    'outInvertsSweep': true,
    'scaleIsotropically': false
};

(In reply to Marco Cecchetti from comment #0)
> 
> 2) For a list of transition type constant look at:
>
> You need to update aTransitionTypeInMap, aTransitionTypeOutMap, 
> aTransitionSubtypeInMap and aTransitionSubtypeOutMap accordingly.
> 


The aTransitionSubtypeOutMap and the aTransitionTypeOutMap were removed on on Jan 23, 2017 because the reverse mapping can be done at run time. 

https://github.com/LibreOffice/core/commit/30672569d5576e86ea47e92c8bcb40416ebadd7c