| Summary: | EDITING: Remove "conditional formatting" not always successful | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | pierre-yves samyn <pierre-yves.samyn> |
| Component: | Calc | Assignee: | Markus Mohrhard <markus.mohrhard> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | 3.6.0.2 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | BSA target:3.7.0 target:3.6.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Sample document
Step4BeforeRemove AfterStep4 |
||
Thanks for the bug report. I think I understand the problem. The cell property is correctly deleted but the last cell column/row can't be removed from ScRangeList. I'll fix ScRangeList and adjust the caller. I have finally a fix for master but need a bit time to check that it is safe for the release branch. Will be only in master for now. Markus Mohrhard committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f56b5e8d4abf17682aa75b7cf183b883809234 delete conditional format entries that are removed, fdo#52351 Markus Mohrhard committed a patch related to this issue. It has been pushed to "libreoffice-3-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=73a465ed443e820974600ee291e21ed6413ecb9d&g=libreoffice-3-6 delete conditional format entries that are removed, fdo#52351 It will be available in LibreOffice 3.6.1. Hello Markus (In reply to comment #4) > Markus Mohrhard committed a patch related to this issue. > ... > It will be available in LibreOffice 3.6.1. Still occurs with Version 3.6.1.2 (Build ID: e29a214) & Windows 7 64bits Regards Pierre-Yves I can't reproduce this with master. Can you please add detailed instructions how you were able to reproduce it? Created attachment 66220 [details]
Step4BeforeRemove
Selection of all conditions then click the Remove button
Created attachment 66221 [details]
AfterStep4
After deleting the conditional formatting, the file is not considered changed: icon save button is not enabled, you can close without warning.
Ok, this is a known but different problem. The dialog can at the moment only handle one selected element. This will be fixed for 3.7 but most likely not for 3.6 The bug I fixed here is that deleting a row or column with a conditional format, did not result in deleting the conditional format. Actually this is already fixed in master and can't be backported without problems. I'm closing this bug for now, if I see a simple solution to fix this in 3.6 I will reopen and fix it. |
Created attachment 64496 [details] Sample document Hello Remove "conditional formatting" not always successful, it depends on the procedure used. Steps to reproduce: 1. Open attached sample document 2. Format> Conditional formatting> Manage Dialog opens with 2 lines, respectively B1:B1048576 and B2 3. Select (mouse and <shift> or <Ctrl>) the 2 lines 4. Click Remove then Ok Expected results : - chosen conditional formatting deleted - "Is modified state" of document to true Actual result : "Is modified state" of document to false 5. "Save As", give another name e.g. "a.ods" 6. File> Reload (to be sure) 7. Format> Conditional formatting> Manage Conditional formattings still there. Platform : Windows 7 64bits and Version 3.6.0.2 (Build ID: 815c576) Regards Pierre-Yves