| Summary: | LibreOffice icons are larger than other app's icons in GNOME Classic | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Sanchit Gangwar <sanchitgangwar> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | minor | CC: | kainz.a, michael.meeks, sanchitgangwar, sknorr.os |
| Priority: | medium | ||
| Version: | 3.5.4 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103303, 106228 | ||
| Attachments: |
Screenshot of icons.
A proposed patch. 24x24 icons 24x24 hicolor icons |
||
As I recall you(?) were asking on IRC how to help fix it - by installing smaller icons, or somesuch ? It's entirely possible that our icons are the same size, and simply fill the surrounding bbox too well - where other icons leave space for shadows / other features (?) Or it could be that they are simple larger. Thoughts / investigation appreciated. Can confirm on OpenSUSE 12.1... so probably not a Ubuntu packaging bug. We probably really lack a certain icon size. It's also a bit odd that the menu doesn't force the icon into place... so, maybe it would be a good idea to file the bug at Gnome additionally. (In reply to comment #1) > As I recall you(?) were asking on IRC how to help fix it - by installing > smaller icons, or somesuch ? > > It's entirely possible that our icons are the same size, and simply fill the > surrounding bbox too well - where other icons leave space for shadows / other > features (?) Or it could be that they are simple larger. > > Thoughts / investigation appreciated. Yes, I'm the same. In fact, I resized the icons to the appropriate size, but the guys at Ubuntu told me to send this bug upstream. As for the problem, yes, it is genuine. The icons available are 16x16, 32x32, 48x48, and so on. The 24x24 icons are missing, hence the gnome-panel uses 32x32. You need to include 24x24 icons. Created attachment 65624 [details]
A proposed patch.
Here is the patch, I created.
Created attachment 65625 [details]
24x24 icons
These are the 24x24 icons which are currently missing.
Hi Sanchit, I am sorry, but your icons are not pixel-aligned -- meaning the horizontal and vertical lines in the icons are rather squishy/fuzzy. It is a better idea to use the official SVG icons from [1], scale the 32*32 icon down and then make sure the everything is aligned neatly. (In Inkscape, you can use the # key to enable the pixel raster. Under View > Icon Preview you can also enable a smaller preview.) Can you try reworking those icons in this way? [1] http://wiki.documentfoundation.org/File:LibreOffice_Initial_Icons-pre_final.svg Sure I'll submit a patch as soon as possible. Created attachment 67327 [details]
24x24 hicolor icons
I've added 24x24 icons again. Please have a look.
Comment on attachment 67327 [details]
24x24 hicolor icons
@Astron: ping? Could you recheck?
Sorry for not commenting on the new icons before. Somehow, this missed me. In any case, the revised icons are now of apparently arbitrary sizes, like 19*24 or 26*24 and still don't have proper pixel alignment... so, these aren't better. @Björn: could you tell me where these icons need to go in the repo? By accident I just stumbled upon (almost) fitting icons in icon-themes/galaxy/res/lx032[42,45,46,47,49,50,51] All they need is cutting of two pixel of shadow. Oh, and we'd still need the printer admin icon if that thing still exists. ^cutting of^cutting off ^pixel^pixels ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: *Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later) https://www.libreoffice.org/download/ *If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior *If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT *Update the version field *Reply via email (please reply directly on the bug tracker) *Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-04-18 ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.5 or 5.2.1 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20160920 can someone verify it bug? all app icons are available in 16, 22, 24, 32, 48, 64, 128, 256, 512, 1024 and scalable so this bug should be closed. |
Created attachment 65566 [details] Screenshot of icons. When using gnome-session-fallback (GNOME Classic session / gnome-panel) then LibreOffice icons are much larger image dimensions than the other icons in the menu.