Bug 55022

Summary: FILEOPEN: CRASH during "Adapt row height" when opening particular .ods
Product: LibreOffice Reporter: Iain Butler <iainbutler>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ginho, iainbutler, markus.mohrhard, quantum.projects, serval2412
Priority: medium    
Version: 3.6.1.2 release   
Hardware: Other   
OS: All   
Whiteboard: BSA target:3.7.0 target:3.6.3
Crash report or crash signature: Regression By:
Attachments: spreadsheet crashing during FILEOPEN "adapt row height"
spredsheet opened in OOo 3.4.1 then "save as", opens OK in LibO 3.6.1
console logs + bt on master

Description Iain Butler 2012-09-17 15:18:49 UTC
Created attachment 67285 [details]
spreadsheet crashing during FILEOPEN "adapt row height"

Problem description: 
A particular .ods spreadsheet file causes LibO 3.6.1.2 to crash midway through FILEOPEN "Adapt how height" phase. Local installations and portable versions of 3.6.1.2 exhibit the same behaviour. However, the file opens normally in 3.5.5.3 and 3.5.6.2.

See also this thread http://en.libreofficeforum.org/node/4326

Steps to reproduce:
1. Open new LibO 3.6.1.2 spreadsheet document
2. File > Open > select attached sample file > double click

Current behavior:
LibO crashes partway through the "Adapt row height" phase of loading the file, with the message "LibreOffice 3.6 has stopped working". Memory usage is not excessive, so this bug is distinct from #44420.

Expected behavior:
Normal loading of the file, as occurs in LibO 3.5.5.3 (Windows, portable) and 3.5.6.2 (Linux).

Platform (if different from the browser): 
Windows 7 x64
              
Browser: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.89 Safari/537.1
Comment 1 Iain Butler 2012-09-17 15:58:07 UTC
From user Lupp at http://en.libreofficeforum.org/node/4326#comment-19855:

"The similar bugs (LibreOffice - bugzilla) I mainly checked were:
40650 - Ver 3.4.3 - filed 2011-09-06
44420 - Ver 3.4.4 - filed 2012-01-03
44758 - Ver 3.4.4 - filed 2012-01-13

I fed your file into OOo 3.4.1 (Apache) and that worked fine. After a new file store (save as) the file had shrunk a bit AND could be opened by LibO 3.6.1 too. If the row heights are as you like them now I cannot judge. "
Comment 2 Iain Butler 2012-09-17 15:59:55 UTC
Created attachment 67288 [details]
spredsheet opened in OOo 3.4.1 then "save as", opens OK in LibO 3.6.1

From user Lupp at http://en.libreofficeforum.org/node/4326#comment-19855

"I fed your file into OOo 3.4.1 (Apache) and that worked fine. After a new file store (save as) the file had shrunk a bit AND could be opened by LibO 3.6.1 too. If the row heights are as you like them now I cannot judge."
Comment 3 Iain Butler 2012-09-17 16:21:57 UTC
Lupp retracted the claim that the version saved from OOo 3.4.1 opens in LibO 3.6.1. Apologies for the multiple postings.
Comment 4 Julien Nabet 2012-09-17 21:18:47 UTC
Created attachment 67297 [details]
console logs + bt on master

On pc Debian x86-64 with master sources updated today, I reproduced the bug.

I attached console logs + bt.
Comment 5 Markus Mohrhard 2012-09-18 15:05:04 UTC
To debug this one I need a dbgutil build.
Comment 6 claupers 2012-09-24 17:14:52 UTC
In tests in version 3.6.2.1 this problem was solved. The test was done with Operating system Windows 8 64-bit. To perform the test, was located by windows Explorer a file that had the error in version 3.6.1. He was given two clicks and the file opened without problems.
Comment 7 Markus Mohrhard 2012-09-24 17:25:47 UTC
No this problem is not fixed. It is just an out of bounds acces so it will fail sometimes and sometimes it will just work. I have a dbgutil build and now just need time to investigate this one.
Comment 8 Not Assigned 2012-09-26 18:08:15 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=70412d0f3f7979d3d069be8121d49dbb96775cce

don't access out of bound array index, fdo#55022



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Markus Mohrhard 2012-09-26 22:44:59 UTC
*** Bug 53610 has been marked as a duplicate of this bug. ***
Comment 10 Michael Meeks 2012-09-27 09:05:28 UTC
Pushed Markus' patch to -3-6 - thanks ! :-)
Comment 11 Not Assigned 2012-09-27 09:10:11 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "libreoffice-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=541fbcd2fae54a7b8bce25873d4d1b4891c1c796&g=libreoffice-3-6

don't access out of bound array index, fdo#55022


It will be available in LibreOffice 3.6.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Markus Mohrhard 2012-10-01 18:01:16 UTC
*** Bug 55479 has been marked as a duplicate of this bug. ***