| Summary: | IDE: Crash when inserting a simple macro | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Julien Nabet <serval2412> |
| Component: | BASIC | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | michael.meeks |
| Priority: | medium | ||
| Version: | 4.0.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | BSA target:3.7.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bt + console logs on master | ||
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bf7240d0676b4350892e01fa8c1ba5eb6a3913c6 Resolves: fdo#56473 IDE: Crash when inserting a simple macro The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks so much for fixing this Julien ! :-) I guess you're going to push an updated patch before closing this ? Thanks ! Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=465ab1c1263b76e3284f18219678e46a211c5605 Related: fdo#56473 IDE: Crash when inserting a simple macro The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael: I added "i" variable in the loops but about removing iterators completely, I don't know how to do. I'm stuck between cast, std::vector and std::auto_ptr. Too complicate for me. So put it RESOLVED/FIXED since I don't reproduce the crash. Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a73c98a708ee41b8c4cf4f2063c5bc4b30044284 Better fix for fdo#56473, Crash when inserting a simple macro The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 69168 [details] bt + console logs on master Problem description: On pc Debian x86-64 with master sources updated today. I tried to reproduce fdo#39449 and when I put the lines in IDE, it crashed. Steps to reproduce: 1. Open Calc 2. Menu Tools/Macro/Organize Macros/LibreOffice Basic 3. Click Edit button 4. Replace the main sub by: Sub HelloWorld msgbox "Hello World!" End Sub Current behavior: Crash Expected behavior: No crash Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.9) Gecko/20100101 Firefox/10.0.9 Iceweasel/10.0.9