| Summary: | CRASH when I click on FORMATS in advanced option of search dialog box. | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | ydutrieux |
| Component: | UI | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arnaud.versini, caolan.mcnamara, jbfaure, michael.stahl, nthiebaud, pierre-yves.samyn, serval2412, wk661lo |
| Priority: | medium | Keywords: | regression |
| Version: | 4.0.0.0.beta1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | bibisected40 target:4.1.0 target:4.0.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Bibisect log
bt + console logs on master |
||
|
Description
ydutrieux
2012-12-17 18:18:25 UTC
I confirm under Ubuntu 12.04 Hello I confirm with Windows 7 64bits Regards Pierre-Yves Reproducible in Version 4.0.0.0.beta1+ (Build ID: 51ecd2f55d608f853852335808b643f61b9a844) under Ubuntu 12.04 x86_64 Best regards. JBF Created attachment 71732 [details]
Bibisect log
Created attachment 71775 [details] bt + console logs on master On pc Debian x86-64 with master sources updated today (commit 8a028afd55decfd269268d0d1e6adcfbdc9d85d0) and a brand new LO profile, I reproduced the crash. Attached bt + console logs. Michael: I noticed this:
#2 0x00007f7fff16b621 in *__GI___assert_fail (assertion=0x7f7fdf2f1494 "aText.Len()", file=<optimized out>, line=232, function=
0x7f7fdf2f18a0 "void FontPrevWin_Impl::CheckScript()") at assert.c:81
#3 0x00007f7fdf13b7c4 in FontPrevWin_Impl::CheckScript (this=0x5dcff90) at /home/julien/compile-libreoffice/libo/svx/source/dialog/fntctrl.cxx:232
+ this:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d1f4649ee72dd85e1d994ac2bdccc3147830bbd
so, one for you?
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2dd3acd205cb8df959ac03e99b1d1991cc562a8 fdo#58427: fix another crash in SvxFontPrevWindow::Paint The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. soo... given the bibisect log from Werner (thanks a lot!) the crash was introduced somewhere in the widget layout merge. crash because SvxFontPrevWindow::Paint cannot set pImpl->aText to a non-empty string; similar crash was fixed in another dialog with http://cgit.freedesktop.org/libreoffice/core/commit/?id=86b6bf6e53c234e3df951ebb08513b0d4fc47a14 comparing with my latest master build from before that (44aa7df6) shows that the old code used to return "Example" for Window::GetText(), while newer code returns empty "". so we could somehow that "Example" window title... but perhaps it's better to add another fallback instead, i see that there is some example text that is only requested if CTL or CJK are active, let's try to request that as a fallback too... ... hmm "Lorem ipsum", at least we're speaking a universal language now :) Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cf4f78955d3a3cd33ff6997d4bd741d0531cf88&g=libreoffice-4-0 fdo#58427: fix another crash in SvxFontPrevWindow::Paint It will be available in LibreOffice 4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |