Bug 60430

Summary: UI shows "Delete comment" in context menu althoug it's impossible because of protected section
Product: LibreOffice Reporter: Rainer Bielefeld Retired <LibreOffice>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: minor CC: giorgio.migliaccio, jorendc, LibreOffice, website
Priority: medium    
Version: Inherited From OOo   
Hardware: Other   
OS: Windows (All)   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=61218
Whiteboard: BSA
Crash report or crash signature: Regression By:
Attachments: Sample Document with comments

Description Rainer Bielefeld Retired 2013-02-07 16:54:48 UTC
Created attachment 74365 [details]
Sample Document with comments

Right Click on Comment in Protected Section offers 'Delete ...' although that's impossible because comment is related to a protected section. Menu items should be greyed out

Steps how to reproduce [Reproducible] with of "LibreOffice 3.6.5.2 " German UI/ German Locale [Build-ID: 5b93205] {pull date 2013-01-18} on German WIN7 Home Premium (64bit):
1. Open attached sample.ods
2. Rightclick any comment
   Expected: greyed out "Delete ..." Items because section
             is write protected
   Actual: Menu Items look active

For your tests:
PW is "12345"
              
Operating System: Windows 7
Version: 4.0.0.2 rc
Comment 1 Rainer Bielefeld Retired 2013-02-07 17:00:01 UTC
OOps, wrong Component!

I already see that in OOo 3.1.1, so inherited. 

@Giorgio:
Can you confirm this problem?
Comment 2 Rainer Bielefeld Retired 2013-03-11 05:11:44 UTC
No objections, so NEW
Comment 3 Jorendc 2014-01-31 15:25:51 UTC
Looks fixed to me http://opengrok.libreoffice.org/xref/core/sw/source/ui/docvw/AnnotationMenuButton.cxx#68

The 'Delete comment' option isn't listed anymore, when clicking on the drop-down arrow on an comment. 'Delete all comments' and 'Delete all comments by <author>' is still active. Makes sense, because you still can delete comments from that author, or all other comments.