| Summary: | EMF+ files rendered as empty boxes | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | kaare |
| Component: | graphics stack | Assignee: | Muthu <muthu.subramanian.karunanidhi> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | chris.sherlock79, fridrich.strba, frob, michael.stahl, muthusuba, robinson.libreoffice, rodo, serval2412 |
| Priority: | medium | ||
| Version: | 4.1.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=59405 https://bugs.freedesktop.org/show_bug.cgi?id=60651 |
||
| Whiteboard: | BSA target:4.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Visio 2010 vdx file
Well-known Cisco's "router" icon in EMF format. |
||
Clarify language of title: "Libvisio: Cisco stenciels donest get shown correctly" -> "Libvisio: Cisco stencils are not displayed properly" On pc Debian x86-64 with master sources updated today, on the 5 stencils, only 2 display. Fridrich: one for you? Created attachment 75057 [details]
Well-known Cisco's "router" icon in EMF format.
Fridrich, 3 of 5 shapes are using stencils. All stencils are 'ForeignShape' with wrapped EMF. 2 other shapes are unreferenced EMF files. Half filled shape (2nd from the left) is EMF incorrectly handled by LO. I extracted it, see attached file. The emf files are extracted by libvisio just fine, only that LO emf+ renderer does not render them right :( Comment on attachment 74589 [details] Visio 2010 vdx file this appears to be a better mime-type... at least according to http://support.microsoft.com/kb/310331/de ah nice my fix for bug 59405 lets the attached EMF show up... the EMF attachment is fixed by bf8450cfa2e9e899c716fbddadd7d5485aefe520, which simply writes the comments into the file; no idea if that is a good idea in general though. there are still 2 emtpy boxes in the Visio file. looks good in current 4.0 branch and master 80885bf2 but again broken in current master: the second and third images now don't have a white background (as in Visio2010) but a black one. ... aha ... git bisect says: commit 4bc3ead0649bf2885050ec4cfb47a5ed13bfa41e Author: Muthu Subramanian <sumuthu@suse.com> Date: Thu Apr 25 11:57:59 2013 +0530 n#812793: (Workaround) Transparent background import in EMF+. EMF+ seems to have alpha of 0xff for transparent background! Looks like I put the workaround in FillPolygons rather than FillRects. Nevertheless, it is still a workaround, please do let me know if it breaks any other document as well. [PS: I still haven't been able to figure out what makes MS consider as transparent during the background fill - while what is stored in the image is actually white :( ] Muthu Subramanian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a1d77327867ae9b80bc676d67f1f70a5d8a2fd4 fdo#60638: Workaround should be in FillRects rather than FillPolygon. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. marking this as fixed, so that somebody can verify. |
Created attachment 74589 [details] Visio 2010 vdx file Problem description: When loading a Visio (2010) drawing the Cisco stencils does not get shown correctly Current behavior: When opening the drawing some stencils are missing Expected behavior: All Stenciels should show up. Operating System: Ubuntu Version: 4.1.0.0.alpha0+ Master