| Summary: | clean obsolete tools/ filesystem abstraction | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Michael Meeks <michael.meeks> |
| Component: | LibreOffice | Assignee: | Tomáš Turek <osmman> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
| Priority: | medium | ||
| Version: | 4.0.0.3 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
Hi, I push a patch to gerrit https://gerrit.libreoffice.org/2968 tools/source/fsys/wntmsc.hxx and tools/source/fsys/unx.hxx are no more, closing. Andras Timar committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=75e014c30753f635ddc74cdb654a8342049a114b fdo#61514 clean obsolete tools/ filesystem abstraction The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup) [NinjaEdit] |
We have these files: tools/source/fsys/wntmsc.hxx tools/source/fsys/unx.hxx that essentially duplicate system abstraction information from sal/ of course - we're trying to write all that cruft out slowly, and this should be easy to help out with. eg. removing: #define DRIVE_EXISTS(c) ( TRUE ) in the unx header would be good. Replacing #define PATHDELIMITER ";" from the wntmsc.hxx header at it's use-sites with SAL_PATHSEPARATOR would be better NB. delimiter -> separator ;-) it's the wrong name. And so on - lots of little things to clean up there. Thanks ! :-)