Bug 64105

Summary: Open the findbar by using menu entry (Edit > Find...) result in a crash
Product: LibreOffice Reporter: Jorendc <jorendc>
Component: UIAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: major CC: arnaud.versini, caolan.mcnamara, serval2412
Priority: high Keywords: haveBacktrace, regression
Version: 4.1.0.0.alpha0+ Master   
Hardware: Other   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: backtrace log

Description Jorendc 2013-05-01 10:35:16 UTC 
Created attachment 78712 [details]
backtrace log

How to reproduce:

* Open Writer
* Edit > Find ...

Behavior: crash

tested using Linux Mint 14 x64 with LibreOffice Version: 4.1.0.0.alpha0+
Build ID: a514c72071a4e572bb712f78b8b119ed0b2eb6b 
Last commit included in build: 
commit a514c72071a4e572bb712f78b8b119ed0b2eb6b2
Date:   Tue Apr 30 11:27:46 2013 -0400

Kind regards,
Joren
Comment 1 Jorendc 2013-05-01 10:49:50 UTC 
Build with:

--enable-debug
--without-doxygen
--enable-werror
--enable-dbgutil
--with-parallelism=2
--disable-odk
Comment 2 retired 2013-05-01 11:29:13 UTC 
Verified on 10.8.3. Open Master build of 2013-05-01 and get immediate crash when opening LO.
Comment 3 Julien Nabet 2013-05-01 13:19:06 UTC 
On pc Debian x86-64 with master sources updated today, I reproduce this with same bt (so I won't attach bt).
I also have enable-dgbutil in my autogen.input.

I noticed these console logs:
warn:legacy.osl:13285:1:vcl/source/app/dbggui.cxx:1750: SolarMutex not locked
soffice.bin: /home/julien/compile-libreoffice/libo/vcl/source/app/dbggui.cxx :1751 : void ImplDbgTestSolarMutex():  The assertion « bCheck » failed.

I also noticed that Ctrl+F shortcut hasn't crashed LO

Caolán: one for you? vcl appears in bt + I wonder if it could be linked to find & replace ui conversion (http://cgit.freedesktop.org/libreoffice/core/commit/?id=b80e865d369b4d94f29ac6dcc27379d3c6e72ada), this commit may have triggered a buggy part.
Comment 4 Arnaud Versini 2013-05-01 13:20:59 UTC 
No crash under Ubuntu 13.04 with no dbg utils and without debug.
Comment 5 Caolán McNamara 2013-05-01 13:52:23 UTC 
Its unrelated to the widget conversion stuff, the "enable-dgbutil" stuff adds extra tests, and apparently the solarmutex should be acquired before forcing focus into the findbar on launching that find command.

I saw you guys chatting about that earlier, so I committed http://cgit.freedesktop.org/libreoffice/core/commit/?id=761f4572daf3ab10fd9ebffbc8327c4669be8220 before I realized there was a bug open for it.
Comment 6 Jorendc 2013-05-01 14:12:57 UTC 
(In reply to comment #5)
> Its unrelated to the widget conversion stuff, the "enable-dgbutil" stuff
> adds extra tests, and apparently the solarmutex should be acquired before
> forcing focus into the findbar on launching that find command.
> 
> I saw you guys chatting about that earlier, so I committed
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=761f4572daf3ab10fd9ebffbc8327c4669be8220 before I realized there was a
> bug open for it.

WHOAH! :o that's euh ... awesome :D

Problem fixed when I do a 'git pull -r' and 'make svx'. Thanks Caolan for this awesome work! Thanks James, Arnaud and Julien for the help. 

Kind regards,
Joren
Comment 7 Julien Nabet 2013-05-01 14:22:00 UTC 
Caolán: Thank you for the explanation and your very quick feedback about this.