| Summary: | Writer crash when open Bibliography Database | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | hot123tea123 |
| Component: | Writer | Assignee: | Lionel Elie Mamane <lionel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jbfaure, lionel, serval2412 |
| Priority: | medium | ||
| Version: | 4.0.3.3 release | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=101810 | ||
| Whiteboard: | BSA target:4.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | console + bt with symbols on master sources | ||
Created attachment 79138 [details]
console + bt with symbols on master sources
On pc Debian x86-64 with master sources updated today, I reproduced the crash.
I attached bt + console logs
Put it at New Lionel: one for you? This patch allows me to open Bibliography but perhaps it's completely wrong because it only masks the bug:
diff --git a/forms/source/component/ListBox.cxx b/forms/source/component/ListBox.cxx
index f26a574..33a1f09 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -1128,7 +1128,7 @@ namespace frm
aSelectionIndicies[0] = m_nNULLPos;
}
}
- else
+ else if (!m_aConvertedBoundValues.empty())
{
ValueList aValues( impl_getValues() );
assert( m_nConvertedBoundValuesType == getValueType());
Just some investigations I made before the patch: I runned gdb and noticed that "m_nConvertedBoundValuesType" has random value (should it be initialized to fix value, 0 or something else?). Then I gave a look to "impl_getValues" method. (line 1036 of forms/source/component/ListBox.cxx) "m_aConvertedBoundValues" and "m_aBoundValues" are empty so we go to line 1049: Sequence< OUString > aStringItems( getStringItemList() ); but getStringItemList is empty too Anyway in this part, "m_nConvertedBoundValuesType" doesn't seem to be changed too. So when come back to OListBoxModel::translateDbValueToControlValue, the assert can't succeed. I do not reproduce the crash under Xubuntu 12.04 x86-64 neither with LibreOffice 4.0.3.3, nor LO 4.0.4.0+. Bibliography database opens as expected. Best regards. JBF (In reply to comment #6) > I do not reproduce the crash under Xubuntu 12.04 x86-64 neither with > LibreOffice 4.0.3.3, nor LO 4.0.4.0+. Happens only in debug builds. Lionel Elie Mamane committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e5b9865fa6e1f7de77ebe1464b4eb964ff61006 fdo#64456 impl_getValues always set m_nConvertedBoundValuesType The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Problem description: Writer crash when I open the Bibliography Database, and tell me to restore the current document. Steps to reproduce: 1. Choose Tools - Bibliography Database Current behavior: Writer crash Expected behavior: edit Bibliography Database Operating System: Windows XP Version: 4.0.3.3 rc