| Summary: | UI: the AutoText icon on the Insert toolbar has no more arrow to choose AutoText | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | pierre-yves samyn <pierre-yves.samyn> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, rb.henschel, timofeev.i.s |
| Priority: | medium | Keywords: | regression |
| Version: | 4.1.0.3 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.2.0 target:4.1.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
pierre-yves samyn
2013-07-20 09:30:37 UTC
It was OK in Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd325abf1ac077904985) It is broken in Version: 4.1.0.0.beta2 Build ID: 33224f4f11a05cfad2249e812fcc2975fbb61f6 Ivan Timofeev committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a645a14cf46a1160c426052823772ad117f0bd8b Related: fdo#67113 restore some code, it has side effects The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolan, reverting your commit 0741054cb9f58fe6e021fe04fb477f0e56366d9e "glossary/autotext isn't a toggleable dialog" helps here. This toolbutton registers as SwTbxAutoTextCtrl::RegisterControl(FN_GLOSSARY_DLG, pMod ); SwTbxAutoTextCtrl defined as SFX_IMPL_TOOLBOX_CONTROL( SwTbxAutoTextCtrl, SfxBoolItem ); i.e. with *SfxBoolItem*, but FN_GLOSSARY_DLG is SfxVoidItem EditGlossary FN_GLOSSARY_DLG i.e. *SfxVoidItem* so the following condition in SfxToolBoxControl::CreateControl is false (line 339): (rFactories[nFactory]->nTypeId == aSlotType) therefore it fails to create SwTbxAutoTextCtrl and returns NULL. So... I wonder if changing FN_GLOSSARY_DLG to SfxBoolItem is a right fix here? Bah, what I *wanted* to happen is that insert->autotext doesn't show a toggle checkbox but I was unaware of the toolbox stuff Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb98778dbf761a0c88c96117add00a66e5cc6c95 Resolves: fdo#67113 split insert autotext and field controls The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. can you double check this all works ok now in master and if so I'll propose for 4-1 It works for me in master, thanks :) Ivan Timofeev committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab79f3def7ce98d27e096e6b40203787dde2f3fb&h=libreoffice-4-1 Related: fdo#67113 restore some code, it has side effects It will be available in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf908fbf1119446000fe75c57f15d08046b8091d&h=libreoffice-4-1 Resolves: fdo#67113 split insert autotext and field controls It will be available in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Hello WORKSFORME with Version: 4.1.2.1 Build ID: bf15ac65c2167fb1ef3daf3710609d4a4c369a9 Thank you :) And sorry for the delay to test... Regards Pierre-Yves |