Bug 69236

Summary:	Slide transition scrollbar is wrongly calculated
Product:	LibreOffice	Reporter:	Thomas Arnhold <thomas-libo>
Component:	Impress	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bubli, caolan.mcnamara, jorendc
Priority:	medium
Version:	4.2.0.0.alpha0+ Master
Hardware:	Other
OS:	All
Whiteboard:	target:4.2.0
Crash report or crash signature:		Regression By:
Attachments:	4.1 working 4.2c: Linux with no scroll bar 4.2b: Windows no scrollbar 4.2a: Windows with scroll bar

Description Thomas Arnhold 2013-09-11 17:59:15 UTC

Created attachment 85653 [details]
4.1 working

The scrollbar for the slide transition frame gets wrongly calculated.

I attached three screenshots:

4.1: Shows how it's correctly working
4.2a: Scrollbar is present.
4.2b: Scrollbar is not present anymore, despite the fact that there is more content hidden.
4.2c: Scrollbar missing on Linux.


Occurs on Windows 7 with Font size set to 125%:

Version: 4.2.0.0.alpha0+
Build ID: a8865e5df62b5f33aa769d459b9823eb5b110d4b
TinderBox: Win-x86@6-debug, Branch:master, Time: 2013-09-03_14:36:22

Occurs on Linux, too:

Version: 4.2.0.0.alpha0+
Build ID: 960aee493a7bdbda69cbe60049edd9c4cafaab8e


Works:

Windows 7 and Linux:
Version: 4.1.1.2
Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903


I suppose this was introduced with the switch to .ui.

Comment 1 Thomas Arnhold 2013-09-11 17:59:59 UTC

Created attachment 85654 [details]
4.2c: Linux with no scroll bar

Comment 2 Thomas Arnhold 2013-09-11 18:00:18 UTC

Created attachment 85655 [details]
4.2b: Windows no scrollbar

Comment 3 Thomas Arnhold 2013-09-11 18:00:40 UTC

Created attachment 85656 [details]
4.2a: Windows with scroll bar

Comment 4 Jorendc 2013-09-13 17:56:01 UTC

Hi Thomas,

Not sure it's still worth to hunt this bug down.

See http://lists.freedesktop.org/archives/libreoffice-qa/2013-September/005221.html

+ switch to pure sidebar mode in master - but not enabled by default, except in Impress (Caolan)

Kind regards,
Joren

Comment 5 Caolán McNamara 2013-09-14 19:47:27 UTC

I see what's going on here. The sidebars request for "what's your preferred size" goes to a pair of hard-coded sizes in getSlideTransitionPanelMinimumHeight and getSlideTransitionPanelMinimumHeight we need to reroute to get_preferred_size (and I wonder if we can get rid of the intermediate DialogListBox widgets or if we need to retain those)

Comment 6 Caolán McNamara 2013-09-14 20:01:40 UTC

aha, I need the DialogListBox for the non-sidebar case where draw manages scrolling itself, but not for the sidebar case where the sidebar handles the scrolling.

This DialogListBox turns out to appear to be a fuller implementation of where I was going with the partially implemented VclScrolledWindow. So might be able to merge those together and profit.

Comment 7 Commit Notification 2013-09-16 10:44:06 UTC

Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=363446eb61de141deb1364805e0d7cd0e1f6d7fe

Resolves: fdo#69236 route size request to layout widget, not hard-coded value



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.