Bug 69570

Summary:	CAB file integrity is checked AFTER uninstalling previous version
Product:	LibreOffice	Reporter:	Pedro <pedlino>
Component:	Installation	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	enhancement	CC:	79045_79045, ilmari.lauhakangas, mikekaganski
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	Windows (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=117492
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	113117

Description Pedro 2013-09-19 11:32:16 UTC

I downloaded an installer for 4.1.2.2 but for some reason the file was corrupted (although it is good enough to get through most of the install process)

Install process run as expected, asking for the usual options, uninstalled the previous version and then stopped with error 1335 reporting that the cab file was damaged.

This left me without any LO version (the previous was uninstalled and the new one wasn't installed because of the corrupted file).

I suggest that file verification is done BEFORE uninstalling the previous version.

If there is some problem with the new installer at least the user can continue to work with the currently installed version.

Comment 1 Mike Kaganski 2019-04-18 06:20:13 UTC

This one is related, but not identical to, bug 117492. This one suggests to make some check before old version uninstallation phase. Possibly that could be done moving RemoveExistingProducts Action from before InstallInitialize (as it is now) to the position just following InstallInitialize - provided it's InstallInitialize which verifies the package integrity (needs checking), see [1] for discussion of RemoveExistingProducts placement. Unlike the problems with bug 117492, which requires major changes in many aspects of installer generation, this change might turn out to be safe.

[1] https://docs.microsoft.com/en-us/windows/desktop/Msi/removeexistingproducts-action