| Summary: | improve coding style in bitmap3.cxx | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Markus Mohrhard <markus.mohrhard> |
| Component: | graphics stack | Assignee: | Milan Zelenka <milanzelenka> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | robinson.libreoffice |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Markus Mohrhard
2014-02-20 03:31:49 UTC
Making it an easy hack Hello, I am willing to work on this "bug". I was wondering if it is ok to submit the WHOLE file with it's diff, or should I submit chunks of about 100 lines each? (In reply to comment #2) > Hello, I am willing to work on this "bug". I was wondering if it is ok to > submit the WHOLE file with it's diff, or should I submit chunks of about 100 > lines each? Please submit a git format-patch or use gerrit.libreoffice.org directly. Hi. I would like to start working on this issue as a part of my assignment at school. The subject is called Open-Source programming. However, I am not fully familiar with the open-source development yet therefore it might take a while before I am finished with my work. The deadline should be at most in 10 weeks, however, I believe I will be done with the work sooner. I hope this delay will not be much of an issue and you will allow me to take my time. Thank you :-) Milan: Great to see you interested in this task! Blocking it is not completely ideal though; so if somebody fixes it before you get to that, you will have to pick another one :-) Having said that, blocking in horizon of days is fine of course - so let us know when you are finished with the LibreOffice build and start the work for real. Until then, it should be still free for others I am afraid - hope it is fine for you! Should you have further questions, feel free to mail me directly - you can do so in Czech ;-) Thank you for the warm welcome :) If somebody takes it it will be sad and unfortunate, but I will probably be able to deal with it :) However if nobody takes it I could start working on it soon since I already have built LO on my computer and I just need to find some free time among my other subjects. I'll keep you posted. Milan Zelenka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=95d7ebd22dd20da5a7a26000494b553944fc23ee Improved coding style as shown in examples fdo#75240 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I assume we can set this EasyHack to Resolved and Fixed? Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup) [NinjaEdit] Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit] |