Bug 75947

Summary: Grammarchecker ignores wrongly set punctuation marks, apostrophs etc.
Product: LibreOffice Reporter: Thomas Hackert <thackert>
Component: LinguisticAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: barta, joao.cormick, misc2006, olivier.dev, sophi, vulcain
Priority: medium    
Version: 4.2.2.1 release   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
Crash report or crash signature: Regression By:

Description Thomas Hackert 2014-03-09 09:31:50 UTC
Hello @ll,
I hope, I have chosen the right component, severity and the like. If not, feel free to change them :)

I discovered the following:

When I create a new Writer document, add e.g.

1. "I am. trying "
(after the last blank pressing <Ctrl>+<Z> to change the capitalized "trying" by LO's autocorrection back to lower case)
2. continuing to type with "to test LO. to find new bugs"
(again pressing <Ctrl>+<Z> after LO has capitalized "to" after the full stop/period

, LO will neither of these two words ("trying" and "to" after the full stops/periods) mark as errors ... :( And I have tried it as well in German (my mother tongue) with an sentence like "Nun teste ich LO. um neue Fehler zu. finden." (again pressing <Ctrl>+<Z>, when LO's autocorrection changed the words "um" and "finden", to change them back to lower case) ... Also an addional <F7> to start LO's spellchecker, does not show them as errors, only showing this "The spell check is complete." message ... :( Interestingly, when I use the spellchecker via <F7>, the "Text language" field is empty – both with my German text and when I have switched the document language to en_US via "Format – Character... – Font" and started to write my English text above ... :(

Discovered with
LO Version: 4.2.2.1 Build ID: 3be8cda0bddd8e430d8cda1ebfd581265cca5a0f and installed Germanophone lang- as well as helppack
OS: Debian Testing i386

Sorry for the inconvenience
Thomas.
Comment 1 vulcain 2014-04-02 19:40:50 UTC
I reproduce this comportment on Ubuntu 12.04 x86_64 in LibreOffice 3.5.7.2 Version ID : 350m1(Build:2) Canonical and in 4.2.3.2 Build ID: 7c5c769e412afd32da4d946d2cb0c8b0674e95e0
The both use by default french language and help.


In french, your test could be translated in
"Je suis. en train d'essayer de tester LO. pour trouver de nouveaux bugs."

I am not an expert but spell-check it's for the word, not for punctuation marks or grammar. If LO change the capitalized it's just an automatic system.

If you want this feature you could use this extension:
http://extensions.services.openoffice.org/project/lightproof
http://extensions.libreoffice.org/extension-center/languagetool

i don't any of them, but i thinks it's that you want.
Comment 2 Olivier R. 2014-04-02 20:53:12 UTC
Goto Menu Tools > Extension manager > English spelling… > Options > Capitalization.

It solves your issue in English.

In LO, grammar checking is only active for few languages by default : English, Hungarian and Portuguese (Brazil).

As LO devs don’t work on spell checking and grammar checking, I assume this issue should be closed. Spell checking and grammar checking are delegated to external teams who work specifically on these subjects.

In German, I don’t know if someone has created a grammar checker able to detect these missing capitalized letters.
The extension LanguageTool may solve this problem. You should try it. I don’t know if there is another one.

For the French language, I should create such a rule in our GC soon.
Comment 3 Thomas Hackert 2014-04-06 14:56:28 UTC
Hello Olivier, *,
sorry for the delay, but did not find the time to answer earlier ... :(

(In reply to comment #2)
> Goto Menu Tools > Extension manager > English spelling… > Options >
> Capitalization.
> 
> It solves your issue in English.

This may solve my problem in English, but not in German ... :(

> In LO, grammar checking is only active for few languages by default :
> English, Hungarian and Portuguese (Brazil).

Why? Is the Germananophone community not large/important enough?

> As LO devs don’t work on spell checking and grammar checking, I assume this
> issue should be closed. Spell checking and grammar checking are delegated to
> external teams who work specifically on these subjects.

I do not think so. This worked in the past but for whatever reason, it does not work any longer ... :(

> In German, I don’t know if someone has created a grammar checker able to
> detect these missing capitalized letters.
> The extension LanguageTool may solve this problem. You should try it. I
> don’t know if there is another one.

I have used LanguageTool in the past, which lead to some other problems – especially, when you were running through MozTrap and something happens differently than descripted in the test run ... ;)

> For the French language, I should create such a rule in our GC soon.

Sophie and the French community would be pleased to hear it ... ;)
Thanks for your answer
Thomas.
Comment 4 Olivier R. 2014-04-06 16:33:16 UTC
Hi Thomas,

(In reply to comment #3)

> > In LO, grammar checking is only active for few languages by default :
> > English, Hungarian and Portuguese (Brazil).
> 
> Why? Is the Germananophone community not large/important enough?

I don’t know. German community is one of the biggest, but it seems that noone took the time to implement a grammar checker with Lightproof. May be most of them are happy with LanguageTool (developed mostly by a German guy).

With Lightproof, it should be easy to create your own minimalistic typographical checker, if you are familiar with regular expressions.
http://cgit.freedesktop.org/libreoffice/lightproof/tree/
See in the folder /doc.
Involving German community is probably the best option.


> > As LO devs don’t work on spell checking and grammar checking, I assume this
> > issue should be closed. Spell checking and grammar checking are delegated to
> > external teams who work specifically on these subjects.
> 
> I do not think so. This worked in the past but for whatever reason, it does
> not work any longer ... :(

OK. I wasn’t aware of this. So if you can specify with what version of LO it worked, it can be tagged as a regression. :)

HTH.
Olivier
Comment 5 Thomas Hackert 2014-04-06 18:00:34 UTC
Hello Olivier, *,
(In reply to comment #4)
> (In reply to comment #3)
> > > In LO, grammar checking is only active for few languages by default :
> > > English, Hungarian and Portuguese (Brazil).
> > 
> > Why? Is the Germananophone community not large/important enough?
> 
> I don’t know. German community is one of the biggest, but it seems that
> noone took the time to implement a grammar checker with Lightproof. May be
> most of them are happy with LanguageTool (developed mostly by a German guy).

I have not the faintest idea, sorry ... :(

> With Lightproof, it should be easy to create your own minimalistic
> typographical checker, if you are familiar with regular expressions.

Alas, I am not ... :( Maybe I will learn it at some point in the future, but at the moment I have more important stuff to learn ... :(

> http://cgit.freedesktop.org/libreoffice/lightproof/tree/
> See in the folder /doc.
> Involving German community is probably the best option.

Hm. I am not a dev, so this link is not of any help for me, sorry ... :( And if I try to find help for this ... That would mean, that I will get answers like "Good idea. When will you be ready with it? I am willing to test it then." ... :(

> > > As LO devs don’t work on spell checking and grammar checking, I assume this
> > > issue should be closed. Spell checking and grammar checking are delegated to
> > > external teams who work specifically on these subjects.
> > 
> > I do not think so. This worked in the past but for whatever reason, it does
> > not work any longer ... :(
> 
> OK. I wasn’t aware of this. So if you can specify with what version of LO it
> worked, it can be tagged as a regression. :)

This is also above my capability ... :( As I have only installed LO 4.1.5.3 and 4.2.3.3, I am not sure, where I had it working in the past (without LanguageTool, that is) and have not the disk space on my netbook to bisect it ... :(
Thanks for your answer and have a nice evening
Thomas.
Comment 6 Olivier R. 2014-04-06 19:55:21 UTC
(In reply to comment #5)

> This is also above my capability ... :( As I have only installed LO 4.1.5.3
> and 4.2.3.3, I am not sure, where I had it working in the past (without
> LanguageTool, that is) and have not the disk space on my netbook to bisect
> it ... :(

Here is a mirror for portable LO :
http://ftp.igh.cnrs.fr/pub/tdf/libreoffice/portable/

You should try with LO 3.6 and 3.3.

(That’s a French mirror, but software is still international. Other mirrors I found don’t seem to keep old versions.)
Comment 7 Thomas Hackert 2014-04-07 08:49:21 UTC
Hello Olivier, *,
(In reply to comment #6)
> (In reply to comment #5)
> > This is also above my capability ... :( As I have only installed LO 4.1.5.3
> > and 4.2.3.3, I am not sure, where I had it working in the past (without
> > LanguageTool, that is) and have not the disk space on my netbook to bisect
> > it ... :(
> 
> Here is a mirror for portable LO :
> http://ftp.igh.cnrs.fr/pub/tdf/libreoffice/portable/

I have no Winblows installed, sorry ... :( But I have found http://downloadarchive.documentfoundation.org/libreoffice/old/ ... ;)

> You should try with LO 3.6 and 3.3.
> 
> (That’s a French mirror, but software is still international. Other mirrors
> I found don’t seem to keep old versions.)

I have tried it with 3.3.04, which shows the same problem. Then I searched for older versions of OOo, but seem only be able to install and run OOo 3.2.1 without any problem ... ;) But alas, this version shows the same problem, so I am out of ideas, what I can do, to find an older version, which also would run on a newer Debian version ... ;)

Sorry for the inconvenience
Thomas.
Comment 8 David H. Gutteridge 2014-07-19 06:07:29 UTC
Given a regression can't be demonstrated, this is presumably best recast as an enhancement request for whoever's responsible for German grammar checking.
Comment 9 Olivier R. 2014-07-19 06:33:53 UTC
Ping to the LanguageTool author.
Comment 10 Daniel Naber 2014-07-19 08:01:02 UTC
Try with "I was. trying to test LibreOffice. to find new bugs" and it will work. The reason is that we have some special cases to avoid false alarms and these also match "am" and "LO".
Comment 11 Thomas Hackert 2014-07-19 15:01:50 UTC
Hello Daniel, *,
(In reply to comment #10)
> Try with "I was. trying to test LibreOffice. to find new bugs" and it will
> work. The reason is that we have some special cases to avoid false alarms
> and these also match "am" and "LO".

why "am"? Do you – by any chance – mean "trying" ;?

The problem is not LO in my sentence

I am. trying to test LO. to find...

, but that LO's spellchecker neither mark "trying" nor "to" as errors (both written with a small letter in the beginning after the full stop instead of a capital letter) ... ;) Should the grammar / spellchecker still not recognize both words as errors? Why should there be a difference in error recognition, when I use "LO" compared to "LibreOffice" (which, btw., also does not work with LO Version: 4.1.6.2 Build-ID: 40ff705089295be5be0aae9b15123f687c05b0a and installed Germanophone lang- as well as helppack under Debian Testing i686, and using "Tools – Language - For all text -> English (USA)" nor when I switch the UI language to English and start my test anew ... :( ). Interestingly, when I try it with LO Version: 4.3.0.3 Build ID: 08ebe52789a201dd7d38ef653ef7a48925e7f9f7 (parallel installed, following the instructions from https://wiki.documentfoundation.org/Installing_in_parallel, also with Germanophone lang- as well as helppack) under Debian Testing, the grammarchecker recognizes both words as errors (blue wavy line below them) ... ;)

Thanks for your answer
Thomas.
Comment 12 tommy27 2015-01-10 13:25:46 UTC
please guys
give an update of the bug current status with latest LibO 4.3.5.2
Comment 13 Olivier R. 2015-01-10 15:02:18 UTC
Issue is WORKSFORME/SOLVED for English (feature bundled in LO), for German (with LanguageTool), for French (with Grammalecte or LanguageTool), and probably for other language as well.

I think the issue should be closed as grammar tools are made by external teams.
Comment 14 tommy27 2015-01-10 16:21:51 UTC
Ok