| Summary: | VIEWING Calc zoom or print preview changes the position of images on the Y axis | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Damien Chambe <damien.chambe> |
| Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | damien.chambe, erack |
| Priority: | medium | Keywords: | regression |
| Version: | 4.2.1.1 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:4.4.0 target:4.3.0.2 target:4.2.6 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Spreadsheet with incorrect image position when you preview/zoom
patch for correct Y picture position with zoom/preview |
||
|
Description
Damien Chambe
2014-03-14 07:42:25 UTC
The fix for this bug appears in /sc/source/ui/view/drawview.cxx : - if (nEndRow<1000) + if (nEndRow<20) It has been corrected, see 31737. But it has been reverted by : http://cgit.freedesktop.org/libreoffice/core/commit/sc/source/ui/view/drawview.cxx?id=bc30ba74e880122b257cc6aa2965a79851fa4608 If you apply the attached patch correction (Same patch in bug #i116848#), zooming and preview are correct. (Tested on linux 64 , libreoffice 4.3.0.0.alpha0+ Build ID: ccd765079ae573d24ded2a07ec434e4e89b619a2 ) I don't know why the commit has been reverted, I don't understand the code, I've just tracked the regression. Created attachment 95779 [details]
patch for correct Y picture position with zoom/preview
reproducible with LO 4.2.1.1 (Win 8.1) Damien Chambe committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b8d84a3bf59212a9652f76d7852c81191b8c8a3b Resolves fdo#76160 Calc invalid image position on zooming The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Damien Chambe committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b708a14d6a9cb0643c6f405a47f4ebd8044494b&h=libreoffice-4-3 Resolves fdo#76160 Calc invalid image position on zooming It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Damien Chambe committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2153e1febbb2ae2254df42d85d33590928b14f5a&h=libreoffice-4-2 Resolves fdo#76160 Calc invalid image position on zooming It will be available in LibreOffice 4.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I'll mark this fixed. |