Bug 77591

Summary: Comment Highlights For Formulas Not Printing
Product: LibreOffice Reporter: Joel Madero <jmadero.dev>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: enhancement CC: caolan.mcnamara, jmadero.dev, jorendc, juanjo.magana
Priority: medium    
Version: 4.3.0.0.alpha0+ Master   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: Document to be Printed
not reproducible?

Description Joel Madero 2014-04-17 19:35:50 UTC 
Thanks to Caolan's work we now can print comments and it includes highlighting of the text that the comment references. But this does not work for formulas. My guess is it might have to do with formulas being treated like images and not text (discussion on bug 75408). 

Steps to Reproduce:
1. Open writer
2. Create a formula
3. Write some text ("TEST") next to the formula
4. Select all
5. Insert comment

Observed: comment appears and everything is highlighted

6. Print

Observed: Highlight is no longer on the formula

Expected: Highlight remains on everything on print.

Note: You can only test this with master from today or later because the patch that is needed was just committed
Comment 1 Joel Madero 2014-04-17 19:36:12 UTC 
Created attachment 97530 [details]
Document to be Printed

Try printing attached document
Comment 2 Juan J. Magaña 2014-04-18 00:40:03 UTC 
I confirm I also have this problem with formulas. In fact, the text that the comment refers to is not highlighted either even when it is text.

I appreciate the work you are doing, Caolán. Thank you very much for your work!
Comment 3 Joel Madero 2014-04-18 01:08:16 UTC 
The text will be - download tomorrow's daily build. But formula still is not
Comment 4 Jorendc 2014-04-18 20:55:10 UTC 
@Joel: not reproducible anymore, tested using Mac OSX 10.9 with version: 4.3.0.0.alpha0+
Build ID: 619b4c40da9e85febbb08a3f7cf8aa8d10963fc1
TinderBox: MacOSX-x86@49-TDF, Branch:master, Time: 2014-04-18_00:07:53

Might be fixed with http://cgit.freedesktop.org/libreoffice/core/commit/?id=fede08ac7d8b9d6c0abd2ba1b09fd3beb1c1b7e7 ?

you mind retesting with a version including that commit :-)?

I'll attach my exported pdf with version mentioned above.

Kind regards,
Joren
Comment 5 Jorendc 2014-04-18 20:56:25 UTC 
Created attachment 97575 [details]
not reproducible?
Comment 6 Joel Madero 2014-04-18 21:23:40 UTC 
:) Unless I can reconfirm it going to mark as WFM -- currently my builds keep failing :(
Comment 7 Juan J. Magaña 2014-04-21 17:03:21 UTC 
Dear Joel,

     It's true that that the builds keep failing. I think it's because of a "<= 4.3.0.0.alpha1" dependency. What I have done is "sudo dpkg --force-depends-version -i *.deb" and then you install the packages. Then, if you don't want the package manager to complain that you have broken packages, you can " gksudo gedit /var/lib/dpkg/status" and replace all the "<= 4.3.0.0.alpha1" for a ">= 4.3.0.0.alpha1".

     With the latest build working, I confirm that both text and formulas are highlighted correctly. Thanks everyone for your efforts, especially Joel and Caolán!
Comment 8 Juan J. Magaña 2014-04-21 17:33:23 UTC 
The only little thing I have noticed is that if the comment covers more than one line, you do have a box around the words covered but it's not highlighted in the resulting pdf. If it's in one line, it's exactly as you see it on the screen.