Bug 78430

Summary:	remove redundant 'private method' comments ...
Product:	LibreOffice	Reporter:	Michael Meeks <michael.meeks>
Component:	framework	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	difficultyBeginner, easyHack, skillCpp, topicCleanup
Priority:	medium
Version:	4.2.4.1 rc
Hardware:	Other
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	Removed redundant comments

Description Michael Meeks 2014-05-08 12:27:48 UTC

cd framework
git grep 'private method'

Makes the code less readable; it'd be good to remove redundant comments like that =)

Comment 1 Hussian Alamri 2014-05-13 16:31:56 UTC

Hello everyone,

I am new as a contributor to LibreOffice but have been a user for many years. I love the work everyone has been doing.

Does this bug require building LibreOffice? If not I will start working on it right away.

-- Hussian

Comment 2 Michael Meeks 2014-05-13 16:43:59 UTC

Building is not so hard =) but no it doesn't really require building. Just get a git checkout, and poke at those files  ...

Comment 3 Hussian Alamri 2014-05-13 22:44:16 UTC

(In reply to comment #2)
> Building is not so hard =) but no it doesn't really require building. Just
> get a git checkout, and poke at those files  ...

I have experience developing and building projects on Linux but at the moment I'm on a Mac (10.9.2) and make failed when I tried to build. Plus I have a slow machine so I don't want to build on it, last time I compiled a project from source it took near 4 hours. I will look further into it but I wanted something I can contribute to quick.

I finished removing the comments. I'm new to git. I did git checkout, is that all or do I also need to do git format-patch origin/master?

Comment 4 Hussian Alamri 2014-05-13 22:53:31 UTC

Created attachment 98998 [details]
Removed redundant comments

I am new to git and LibreOffice source base.

I have removed the redundant comments as in the bug's description. If rejected please let me know how I can fix it.

If accepted, I will be more than glad to do any janitorial work (code cleanup, redundant comments, formatting, etc...).

-- Alamri Hussian

Comment 5 Michael Meeks 2014-05-14 13:21:27 UTC

Hi Hussain - thanks for that ! =) one reason we do this is to gain vertical space - so more can be seen on the screen; it'd be great to have a second clean-up to have just single lines between the functions in framework you touched there I guess.

Anyhow - I've pushed it for now; can you send a license statement to the developers' mailing list:

https://wiki.documentfoundation.org/Development/Developers#Example_Statement

And great to have you involved ! =)

Comment 6 Hussian Alamri 2014-05-15 03:54:51 UTC

Greetings,

Thank you for accepting my patch.

Sure, I will gladly do another cleanup to have single lines between functions.

Where should I send the patch once I'm done? This bug seem to have been closed.

I sent an email to the developers list regarding the license. All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.

Once I'm familiar with LibreOffice I want to contribute in fixing more advanced bugs and/or implementing features.

-- Alamri Hussian

Comment 7 Robinson Tryon (qubit) 2015-12-15 16:27:25 UTC

Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]