| Summary: | Calc freezes when typing " in formula | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Kohei Yoshida <kohei> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | erack, winfrieddonkers |
| Priority: | medium | ||
| Version: | 4.3.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Kohei Yoshida
2014-05-15 02:22:45 UTC
Here is my backtrace (gdb) bt #0 0x00007f7deab7040c in rtl_uString_newConcat () from /home/kohei/libo/my-master/instdir/program/../ure-link/lib/libuno_sal.so.3 #1 0x00007f7dcef19f2a in operator+= (str=..., this=0x7fff6f8a7750) at /home/kohei/libo/my-master/include/rtl/ustring.hxx:355 #2 ScInputHandler::ShowArgumentsTip (this=this@entry=0x2fe1c30, rParagraph=..., rSelText=..., rSel=..., bTryFirstSel=bTryFirstSel@entry=false) at /home/kohei/libo/my-master/sc/source/ui/app/inputhdl.cxx:805 #3 0x00007f7dcef1cee2 in ScInputHandler::UseFormulaData (this=this@entry=0x2fe1c30) at /home/kohei/libo/my-master/sc/source/ui/app/inputhdl.cxx:1094 #4 0x00007f7dcef222fc in ScInputHandler::KeyInput (this=0x2fe1c30, rKEvt=..., bStartEdit=false) at /home/kohei/libo/my-master/sc/source/ui/app/inputhdl.cxx:3146 #5 0x00007f7dcf28af79 in ScTabViewShell::TabKeyInput (this=0x2fbd5d0, rKEvt=...) at /home/kohei/libo/my-master/sc/source/ui/view/tabvwsh4.cxx:1261 #6 0x00007f7dcf207abf in ScGridWindow::KeyInput (this=0x2fc1fd0, rKEvt=...) at /home/kohei/libo/my-master/sc/source/ui/view/gridwin.cxx:3362 Let me take this, I think I know what I broke.. I submitted a patch (https://gerrit.libreoffice.org/#/c/9359/) as it seemes an omission in my patch ... Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4f32eec653596483088c6e5aa37de031278d74c resolved fdo#78718 break the indefinite loop when entering =" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. @Winfried: Wasn't your fault, it was the result of my refactoring that distilled the copypasted code of two functions into ScInputHandler::ShowArgumentsTip() (In reply to comment #5) > @Winfried: > Wasn't your fault, it was the result of my refactoring that distilled the > copypasted code of two functions into ScInputHandler::ShowArgumentsTip() No problem, I'm glad I came up with the same solution. Thanks a lot for the quick fix, you two. |