Bug 79312

Summary:	Disable auto-close of spelling dialog after spellcheck complete
Product:	LibreOffice	Reporter:	Yousuf Philips (jay) (retired) <philipz85>
Component:	UI	Assignee:	Marek Dolezel <marekdolezel>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	fdbugs, h3734236, jmadero.dev, samuel.mehrbrodt, suokunlong, vsfoote
Priority:	medium
Version:	Inherited From OOo
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=152553 https://bugs.documentfoundation.org/show_bug.cgi?id=99289 https://bugs.documentfoundation.org/show_bug.cgi?id=134449
Whiteboard:	target:5.1.0 target:5.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	109527

Description Yousuf Philips (jay) (retired) 2014-05-27 14:23:19 UTC

I think it would be better to have the user click the 'close' button when the spellcheck is complete, so that users can modify things in the dialog like clicking 'check grammar' or changing the spellcheck dictionary.

Presently there is no means of stopping the spelling dialog from the user opening it up and then it automatically showing that its done spellchecking and when after clicking the 'ok' button and then it automatically closing the dialog without giving the user access to change things. I guess if the one work around is that the user can add an incorrectly spelt work. :) But a number of users have mentioned that spellchecking isnt working for them at all (bug 78499), so mispelling something wont help them get access to the dialog.

Comment 1 Kevin Suo 2014-05-29 08:42:53 UTC

(In reply to comment #0)

Confirmed and I agree with Jay Philips. The check grammer dialog should not be closed immediately after completion.

However, this may be an enhancement, changing the Importance accordingly. Feel free to change it back if you disagree.

Comment 2 Yousuf Philips (jay) (retired) 2014-07-05 00:04:53 UTC

Decided to return this to medium as there isnt a workaround to this problem.

Comment 3 Yousuf Philips (jay) (retired) 2014-11-28 04:05:49 UTC

CCing ux-advise to confirm i'm not missing anything in this enhancement.

Comment 4 Marek Dolezel 2015-07-06 11:38:55 UTC

I pushed a patch for gerrit gerrit#16788. Assigning to myself.

Comment 5 V Stuart Foote 2015-07-06 15:50:59 UTC

https://gerrit.libreoffice.org/#/c/16796/

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae20b8147307de84318598be72977abc3f7bdda9

Comment 6 Commit Notification 2016-03-15 14:52:18 UTC

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=940e65304437362f7926042a1eac385802ab3eb9

tdf#79312 sc: Don't close the spellchecker when finished

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.