| Summary: | Slide Transition: Sound list box does not include all sounds when is in non-English UI | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Kevin Suo <suokunlong> |
| Component: | Impress | Assignee: | Julien Nabet <serval2412> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | FirasHanife, serval2412, suokunlong, vulcain |
| Priority: | medium | ||
| Version: | 4.1.6.2 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:4.4.0 target:4.3.0.2 target:4.2.6 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Kevin Suo
2014-06-21 12:57:15 UTC
I'm confirming on openSUSE with 4.1.6.2 (Italian language). Changing Status to NEW. On pc Debian x86-64 with master sources updated today, I could reproduce this. Indeed, sd/uiconfig/simpress/ui/slidetransitionspanel.ui contains only 3 entries, see http://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/ui/slidetransitionspanel.ui#138 Unwinding this, the problem comes from http://opengrok.libreoffice.org/xref/core/svx/source/gallery2/gallery1.cxx#169 Fallback strings are in English, when calling ImplGetThemeEntry (see http://opengrok.libreoffice.org/xref/core/svx/source/gallery2/gallery1.cxx#ImplGetThemeEntry), it compares with localized theme names. I tried to use the other implementation of ImplGetThemeEntry which takes an id as parameter but some theme ("sounds" included) has "0" value, instead of expected "18". Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e4ca1f900a5585d35af04159bdd854f10b495355 Resolves: fdo#80327 Sound list box when non-English UI The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gerrit review for: - 4.3: https://gerrit.libreoffice.org/9845 - 4.2: https://gerrit.libreoffice.org/9846 Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=52613b9b632721ebb5167a4d9529c242a0b907da&h=libreoffice-4-3 Resolves: fdo#80327 Sound list box when non-English UI It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to comment #6) Does it mean that the sound list items will be translatable on pootle after this commit? I do not see any of these strings at this moment. Thanks! suokunlong: no, they'll just appear with the patch. (In reply to comment #8) > suokunlong: no, they'll just appear with the patch. So, I assume: * With this patch, all the sound list items will appear in both english and non-english UI. * Athrough they will appear in non-english UI, they are not translated (they are in english when in non-english UI). Am I correct? If so, I believe we should make these sound names translatable. So maybe another patch is needed? suokunlong: I don't think it's possible since these names correspond to files. See http://opengrok.libreoffice.org/xref/core/extras/source/gallery/sounds/ But perhaps I'm wrong. *** Bug 74314 has been marked as a duplicate of this bug. *** Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a8a97dbc56b9db3ef59c324ada05981d00a14b2&h=libreoffice-4-2 Resolves: fdo#80327 Sound list box when non-English UI It will be available in LibreOffice 4.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Following the push on 4.3 and 4.2 branches, let's put this one to FIXED. \o/ I confirm bug is fixed in LibreOffice 4.3.0.2 Build ID: 14ed55896fdfcb93ff437b85c4f3e1923d2b1409 on Ubuntu 12.04 Tested with french language I confirm this bug is fixed in LibreOffice 4.2.6.1 Build ID: 5fdddf655fba363e34f755715238d0943a44857e Tested on Ubuntu 12.04.4 x86_64 |