| Summary: | UI: ACCESSIBILITY: list Language in dialog Format Character/Style does not respond properly to key strokes | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
| Component: | Writer | Assignee: | Eike Rathke <erack> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | CC: | cno, erack, philipz85 |
| Priority: | low | Keywords: | regression |
| Version: | 4.3.0.2 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.5.0 target:4.3.7 target:4.4.2 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Cor Nouws
2014-07-16 13:19:27 UTC
was fine in old style dialog This has to be set as an enhancement as well. :) Sorry, my bad. This isnt an enhancement, but not a regression. :) (In reply to Jay Philips from comment #3) > Sorry, my bad. This isnt an enhancement, but not a regression. :) It was OK before, so why not a regression? Well they changed the type of control and when they did the change, the functionality isnt functioning correctly. So it is a bug in the new control. And a regression from user perspective :) Yes i'd say it was a regression as it worked correctly before, but its not something that could be bibisected to correct the mistake. :D OK, clear - sort of ;) Set to regression again Adding Whiteboard:bibisectRequest Even though this probably results from a UI conversion, identifying the commit may allow it to be raised back to the committer @eike (In reply to Matthew Francis from comment #9) > Even though this probably results from a UI conversion, identifying the > commit may allow it to be raised back to the committer Wasn't that you ? Yes. Feel free to improve my code ;) This doesn't need a bibisect, code pointer: svx/source/dialog/langbox.cxx IMPL_LINK( SvxLanguageComboBox, EditModifyHdl, ...) the part following const sal_Int32 nPos = GetEntryPos( aStr); (In reply to Eike Rathke from comment #11) > Yes. Feel free to improve my code ;) Maybe we meet in Betacowork ;) Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a448f1bb9221f30f73574c580b506e00bf2ae61a Resolves: tdf#81429 select corresponding listbox entry if not current It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/14457 for 4-4 https://gerrit.libreoffice.org/14458 for 4-3 Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd8a5ecbc0afd7646583fa56b8e6efc3f040012c&h=libreoffice-4-3 Resolves: tdf#81429 select corresponding listbox entry if not current It will be available in 4.3.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0f22bb1db655d86923c16e5c2f7d84489d7a63e&h=libreoffice-4-4 Resolves: tdf#81429 select corresponding listbox entry if not current It will be available in 4.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #16) > Eike Rathke committed a patch related to this issue. > It has been pushed to "libreoffice-4-4": Thanks Eike! (Just wondering later: this can't really be the only place in UI with the same behavior and combination of an edit control and a list box? E.g. Select Style in Writer looks similar from user perspective - I you know how to use it ;) ) |