Bug 82144

Summary:	Building with fetching external sources fails with libreoffice-4.3.0.4
Product:	LibreOffice	Reporter:	Armin K <krejzi>
Component:	LibreOffice	Assignee:	David Tardon <dtardon>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dtardon
Priority:	medium
Version:	4.3.0.4 release
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	Possible Fix

Description Armin K 2014-08-04 17:48:27 UTC

When building libreoffice-4.3.0.4, I notice that it fails to build with the following message (with the fix from bug 82136):



/home/armin/src/libreoffice-4.3.0.4/bin/unpack-sources /home/armin/src/libreoffice-4.3.0.4  /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-dictionaries-4.3.0.4.tar.xz  /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-help-4.3.0.4.tar.xz
Error: /home/armin/src/libreoffice-4.3.0.4 is not a valid LibreOffice core source directory



The problem is in bin/unpack-sources

if ! test -f $start_dir/Repository.mk -a -f $start_dir/solenv/inc/target.mk ; then
    echo "Error: $start_dir is not a valid LibreOffice core source directory"
    exit 1;
fi

solenv/inc doesn't contain target.mk (anymore). I can remove it, but it fails later with following error:



/home/armin/src/libreoffice-4.3.0.4/bin/unpack-sources /home/armin/src/libreoffice-4.3.0.4  /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-dictionaries-4.3.0.4.tar.xz  /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-help-4.3.0.4.tar.xz
Unpacking libreoffice-dictionaries-4.3.0.4...
tar -xf /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-dictionaries-4.3.0.4.tar.xz -C /home/armin/src/libreoffice-4.3.0.4/src
find: `/home/armin/src/libreoffice-4.3.0.4/src/libreoffice-dictionaries-4.3.0.4': No such file or directory
Unpacking libreoffice-help-4.3.0.4...
tar -xf /home/armin/src/libreoffice-4.3.0.4/external/tarballs/libreoffice-help-4.3.0.4.tar.xz -C /home/armin/src/libreoffice-4.3.0.4/src
find: `/home/armin/src/libreoffice-4.3.0.4/src/libreoffice-help-4.3.0.4': No such file or directory
mkdir -p /home/armin/src/libreoffice-4.3.0.4/instdir && install-gdb-printers -a /home/armin/src/libreoffice-4.3.0.4/instdir -c
make -j 4 -rs -f /home/armin/src/libreoffice-4.3.0.4/Makefile.gbuild all   
make[1]: warning: -jN forced in submake: disabling jobserver mode.
/home/armin/src/libreoffice-4.3.0.4/RepositoryModule_host.mk:14: /home/armin/src/libreoffice-4.3.0.4//dictionaries/Module_dictionaries.mk: No such file or directory
/home/armin/src/libreoffice-4.3.0.4/RepositoryModule_host.mk:14: /home/armin/src/libreoffice-4.3.0.4//helpcontent2/Module_helpcontent2.mk: No such file or directory
/home/armin/src/libreoffice-4.3.0.4/Makefile.gbuild:21: *** Corrupted module target stack! .  Stop.
Makefile:224: recipe for target 'build' failed



armin@krejzi:~/src/libreoffice-4.3.0.4$ ls -l src
total 4
drwxr-xr-x 4 armin armin 4096 Jul 25 08:52 libreoffice-4.3.0.4
armin@krejzi:~/src/libreoffice-4.3.0.4$ ls -l src/libreoffice-4.3.0.4/
total 3776
-rw-r--r--  1 armin armin  582444 Jul 25 08:50 ChangeLog-dictionaries
-rw-r--r--  1 armin armin 3272067 Jul 25 08:52 ChangeLog-helpcontent2
drwxr-xr-x 53 armin armin    4096 Jul 25 08:50 dictionaries
drwxr-xr-x  6 armin armin    4096 Jul 25 08:52 helpcontent2

Comment 1 Armin K 2014-08-04 18:39:55 UTC

Created attachment 104013 [details]
Possible Fix

This appears to fix it for me. Not sure how correct it is.

Comment 2 Armin K 2014-08-04 18:40:50 UTC

And bin/unpack-sources is not executable by default.

Comment 3 Caolán McNamara 2014-10-01 08:21:22 UTC

caolanm->dtardon: Any idea why Armin here has a problem building when we don't ?, either way the point that there is no solenv/inc/target.mk but bin/unpack-sources references it seems well made.

Comment 4 David Tardon 2014-10-01 08:33:07 UTC

(In reply to comment #3)
> caolanm->dtardon: Any idea why Armin here has a problem building when we
> don't ?, either way the point that there is no solenv/inc/target.mk but
> bin/unpack-sources references it seems well made.

dtardon->caolanm: When building from git, bin/unpack-sources is not used, so there is no problem. Neither it is used in distro packages, where the extra tarballs are typically downloaded in advance and the unpacking is done by the package building tool itself...