| Summary: | Images pasted / opened from HTML at incorrect size | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mark Bourne <libreoffice-bug.mbourne> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | michael.stahl, philipz85, u20230201 |
| Priority: | medium | Keywords: | regression |
| Version: | 4.3.0.4 release | ||
| Hardware: | x86 (IA32) | ||
| OS: | Windows (All) | ||
| Whiteboard: | target:4.5.0 target:4.3.7 target:4.4.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | html-img-size-demo.html for steps to reproduce | ||
|
Description
Mark Bourne
2014-08-25 19:55:09 UTC
Hello Mark, Thank you for filing the bug. You mentioned in your instructions that opening an attachment, but unfortunately you didnt provide it. Created attachment 107025 [details]
html-img-size-demo.html for steps to reproduce
Sorry about that. Should now be attached.
Thanks for the file. I went through the instructions and see that whenever you click original size, it stretch the image to the size of the window, so if i had the sidebar open, it was smaller than when it was closed. So with the URI it should extract its pixel size and using that size when pasting. I've seen similar circumstances when pasting an svg from a webpage did a similar thing into a regular word document, though i'm not sure if it was URI or URL. Tested on master. Version: 4.4.0.0.alpha0+ Build ID: df73f4115cfe4d07e4159adf087571687eb173ec TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-09-25_23:36:54 possibly a regression in the 8da21eca455134a1d017893a9b1d26f827fba185..da21f7da44dc577a08ea3bc210083dc8decf18bc range This is (somehow) triggered by commit 38faee21e0b874359246e513b0a8c0af399a864d Author: Matúš Kukan <matus.kukan@collabora.com> Date: Tue Sep 23 14:40:01 2014 +0200 Do not link html images only when pasting from clipboard (bnc#580834) Change-Id: I020c4e6ed6d468e553dedd7c91979b081d6b4725 Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4327ee505f8507f653c8f4db9ac7503db2e15c3a Resolves: tdf#83073 use loaded graphic's width/height as defaults It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. add keyword according to comment #5 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d330d1cb36b81026e448dc371075b7bc8c75d33e&h=libreoffice-4-3 Resolves: tdf#83073 use loaded graphic's width/height as defaults It will be available in 4.3.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd53735c5fe98fa4f8da4bf214a04b7883bf73c8&h=libreoffice-4-4 Resolves: tdf#83073 use loaded graphic's width/height as defaults It will be available in 4.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2c562a64da925d96260939181574770224dadad&h=libreoffice-4-4-1 Resolves: tdf#83073 use loaded graphic's width/height as defaults It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I think this bug still is not fixed for 4.3.6.2 on Windows 7: I copied all of a HTML mail message and pasted it into writer. The HTML contains images referenced by CID: (part of the same message). The images all appear with content, but the images all seem to have size 2x1cm. In one case I checked it: When openeing the image properties and select "original size", then the image has size 17x9.26cm. I also checked the HTML: the <img> element contains no specific size attributes, so the images should be displayed in their native size (as done when viewing the HTML message in the mail program). If you think it's a different bug, set this one to resolved again. Is there a work-around that will set all images in a document to "original size" (without doing it one-by-one)? Original codebot claimed that the commit will be in 4.3.7, so "4.3.6.2 still broken" isn't a surprise from that perspective. If it is still broken in 4.3.7, or any of the other versions listed in the comments above, then feel free to file a new bug and put me on cc, but don't re-open this one unless the example of #2 fails Using LibreOffice 4.4.2 on Windows Vista, it's much improved some points from the original steps to reproduce (comment 0 with attachment from comment 2) still happen: Step 4) Is fixed: The image copied from data: URI is pasted at the correct size, and saving results in HTML specifying the original pixel dimensions. Step 5) Not fixed: Setting to "Original Size" sets the image to a larger size than the original size (copied from data: URI). Step 8) Not fixed: Setting to "Original Size" sets the image to a larger size than the original size (copied from http: URI). Step 10) Not fixed: Opening the test document in LibreOffice, the data: URI image is the correct size, but the http: URI image is 2.00 x 1.00 cm. Step 11) Not fixed: Setting to "Original Size" sets the images to a larger size than the original size (both data: and http: URIs from opening test document). Perhaps too many separate issues in one bug report! Should I reopen this one, or file new bugs for the outstanding parts? |