| Summary: | new read-only info bar does not go away when clicking on "edit" | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Lionel Elie Mamane <lionel> |
| Component: | Writer | Assignee: | Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cedric.bosdonnat.ooo, cno, jorendc, lionel, quikee, robert, samuel.mehrbrodt, sberg.fun |
| Priority: | medium | ||
| Version: | 4.4.0.0.alpha0+ Master | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=80538 | ||
| Whiteboard: | target:4.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Base (embedded writer document) reproduction case | ||
I'll have a look at this, thanks for reporting. (In reply to comment #0) > > When opening a stand-alone Writer document that has the property "open in > read-only mode" set, the new read-only info bar does not go away after one > clicks "edit". However, if one clicks "edit" again, the document goes back > to read-only mode. If one clicks "edit" a third time, the infobar disappears. Fix is here: https://gerrit.libreoffice.org/11220 > > In the case of a writer document embedded in Base (which Base calls "form"), > the info bar never goes away. Here are the reproductions steps for this case: > > 1) Open attachment > 2 [details] [review]) In left pane, click "Forms" > 3) Right-click on "Formulaire1" and click on "edit" > 4) Document opens (in design mode). Click "Edit" in info bar. > 5) Click edit several times. The info bar never goes away. Is this fixed with your patch for bug #83302? If the infobar doesn't show up, I don't need to close it... (In reply to comment #2) > (In reply to comment #0) >> In the case of a writer document embedded in Base (which Base calls "form"), >> the info bar never goes away. Here are the reproductions steps for this case: >> 1) Open attachment 105504 [details] >> 2) In left pane, click "Forms" >> 3) Right-click on "Formulaire1" and click on "edit" >> 4) Document opens (in design mode). Click "Edit" in info bar. >> 5) Click edit several times. The info bar never goes away. > Is this fixed with your patch for bug #83302? > If the infobar doesn't show up, I don't need to close it... No. The infobar (with my patch for bug 83302) doesn't show up when the form is opened in normal mode (that is double-click on it, or right-click / open). It *does* show up (and this is desirable) when the form is opened in design mode (right-lick on it and "edit" in the pop-up / contextual menu). (In reply to comment #3) > (In reply to comment #2) >> (In reply to comment #0) >>> In the case of a writer document embedded in Base (which Base calls "form"), >>> the info bar never goes away. >> Is this fixed with your patch for bug #83302? >> If the infobar doesn't show up, I don't need to close it... > No. The infobar (with my patch for bug 83302) doesn't show up when the form > is opened in normal mode (that is double-click on it, or right-click / > open). It *does* show up (and this is desirable) when the form is opened in > design mode (right-lick on it and "edit" in the pop-up / contextual menu). It seems to be fixed by your patch to this bug, though. Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8cf89c24906c6d50a3c15f1ebef4df071ad6ec79 fdo#83311 Fix infobar for documents with read-only property The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 105504 [details] Base (embedded writer document) reproduction case When opening a stand-alone Writer document that has the property "open in read-only mode" set, the new read-only info bar does not go away after one clicks "edit". However, if one clicks "edit" again, the document goes back to read-only mode. If one clicks "edit" a third time, the infobar disappears. In the case of a writer document embedded in Base (which Base calls "form"), the info bar never goes away. Here are the reproductions steps for this case: 1) Open attachment 2) In left pane, click "Forms" 3) Right-click on "Formulaire1" and click on "edit" 4) Document opens (in design mode). Click "Edit" in info bar. 5) Click edit several times. The info bar never goes away.