Bug 83678

Summary:	MySQL connection configuration screen displays port number with thousand separators
Product:	LibreOffice	Reporter:	Lionel Elie Mamane <lionel>
Component:	Extensions	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caolan.mcnamara, dtardon, iplaw67, lionel, serval2412
Priority:	low	Keywords:	regression
Version:	4.4.0.0.alpha0+ Master
Hardware:	x86-64 (AMD64)
OS:	macOS (All)
Whiteboard:	target:4.4.0
Crash report or crash signature:		Regression By:

Description Lionel Elie Mamane 2014-09-09 15:23:47 UTC

+++ This bug was initially created as a clone of Bug #83656 +++

Using master build of LO, enabled building of the mysql connector extension :

--enable-ext-mariadb-connector

I see the extension in the list of registered/bundled extensions : version 1.0.2

1) Open an ODB that connects to MySQL (native)

2) Right click on a blank area in the lower right panel and choose :

Database > Properties

The new dialog UI appears

The port field, displays "3 306" or "3,306" depending on locale

It should display "3306" without thousands separator as was the case before.

This is most probably linked to the .src -> .ui conversion.

Comment 1 Lionel Elie Mamane 2014-09-09 15:29:00 UTC

The author of that conversion, namely Szymon Kłos <eszkadev@gmail.com>, does not seem to have a bugzilla account.

Caolan or David, you would know how to fix this? The culprit control is in dbaccess/uiconfig/ui/mysqlnativesettings.ui, I think it is
                 <object class="GtkSpinButton" id="port">
                    <property name="visible">True</property>
                    <property name="can_focus">True</property>
                    <property name="hexpand">True</property>
                    <property name="invisible_char">•</property>
                    <property name="invisible_char_set">True</property>
                    <property name="numeric">True</property>
                  </object>

There is probably the same problem in the other converted dialogs, if somebody could quickly check them... Thanks in advance!

Comment 2 Commit Notification 2014-09-09 16:21:37 UTC

Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=df5c8887017fe5f5c1726211df3c48347e89e5f8

Resolves: fdo#83678 no thousand seperator for port numbers



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.