| Summary: | bin/gbuild-to-ide includes invalid characters when detecting source and build directory | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | sorrow17 |
| Component: | LibreOffice | Assignee: | Ashod Nakashian <ashodnakashian> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ilmari.lauhakangas, robinson.libreoffice |
| Priority: | medium | ||
| Version: | 4.4.0.0.alpha1 | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Cygwin | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
I have to change this to UNCONFIRMED, because we need someone to reproduce the problem before setting to NEW. (In reply to sorrow17 from comment #0) > Since I am not familiar with libreoffice source code, I don't know if I am > doing the right thing. Could anyone take a look at this? Appreciate your > help! Hi Sorrow, Just so you know: https://wiki.documentfoundation.org/QA/BugReport#Not_all_bugs_go_to_Bugzilla For questions/bugs about building LibreOffice, please send email to the Development mailing list: https://wiki.documentfoundation.org/Development/Mailing_List Thanks! Status -> RESOLVED NOTOURBUG Confirmed, fixed and committed. |
When I try to use "/opt/lo/bin/make vs2013-ide-integration" to generate files for Visual Studio development, it print out thousands of lines saying that "XXX.cxx in project XXX does not exist". Then I open the .sln files in the source directory, nothing is included in the project. But I am quite sure that libreoffce was built within my source directory. After some investigation, I found something weird. At the "GbuildParser" class in the script "bin/vs2013-ide-integration", it seems to uses a set of regex to match some basic information of the project, such as class GbuildParser: ... srcdirpattern = re.compile('^SRCDIR = (.*)') builddirpattern = re.compile('^BUILDDIR = (.*)') instdirpattern = re.compile('^INSTDIR = (.*)') ... which matches source directory and build directory in makefiles. What make me confused is that it will also include some characters invalid in a path, such as '\n' and '\r' on my computer, so the file searching will fail with these characters in next steps. For example, there is a variable recording the actual source directory called "GbuildParser.srcdir", and it will end up with the charater '\r' on my computer and it will return a invalid path. When I modify the line in "bin/gbuild-to-ide" from self.srcdir = srcdirmatch.group(1) to self.srcdir = srcdirmatch.group(1).strip() Things get better and all the files are included in the VS project file. Since I am not familiar with libreoffice source code, I don't know if I am doing the right thing. Could anyone take a look at this? Appreciate your help!