Bug 86334

Summary: EDITING WRITER - cannot undo deleted images afters saving
Product: LibreOffice Reporter: Milos Sramek <msramek22>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: cno
Priority: medium    
Version: Inherited From OOo   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:

Description Milos Sramek 2014-11-16 09:34:59 UTC 
Hi,

if I delete an image in Writer (tested in several version, including the most recent 4.4.alpha2), save the document and subsequently try to undo the deletion, the image is not restored and "Read error" appears in the place of the image. OOo3.3 behaves in the same way. Autosave does not result in this problem. I do not observe this problem in Impress

While on the one hand this behavior can be easily explained, on the other hand I think that the situation should be handled in a more decent way, since a user may be confused and may regard this as an internal LO bug. It may easily happen that the user does not realize that this was caused by earlier deletion and subsequent saving. 

I see two possibilities how to handle this situation:
- Change the "Read error" message  by a clear explanation: "The deleted image is no more available after saving". 
- Do not remove the deleted images from cache on saving. 

To repeat:
1 create an empty writer document
2 add an image
3 save the document
4 close LO
5 open the document
6 delete the image
7 save the document
8 hit CTRL-Z: Image is not restored, and "Read error" appears

If steps 4 and 5 are skipped, the image is restored correctly

--
milos
Comment 1 Cor Nouws 2014-11-16 14:06:59 UTC 
Hi  Milos,

> I see two possibilities how to handle this situation:
> - Change the "Read error" message  by a clear explanation: "The deleted
> image is no more available after saving". 
> - Do not remove the deleted images from cache on saving. 

I think a valid request. Set to new.
Thanks,
Cor
Comment 2 Gordo 2015-06-27 16:56:27 UTC 
Could not reproduce.

Windows Vista 64
Version: 4.4.4.3
Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8

4.3.6.2

Bug present in 4.2.8.2.

Changed to RESOLVED WORKSFORME.
Comment 3 Milos Sramek 2015-06-28 08:55:34 UTC 
Hi,

I've checked 5.0.0. and 4.4.3.2 - works correctly in both. Thus, I suggest to change the status to FIXED

Milos