| Summary: | segfault whle closing program after "Autocorrect Options..." | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Terrence Enger <lo_bugs> |
| Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | cloclo2014, d.sikeler94, michael.stahl, serval2412, suokunlong |
| Priority: | high | Keywords: | bibisected, haveBacktrace, regression |
| Version: | 4.4.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=79761 https://bugs.documentfoundation.org/show_bug.cgi?id=89867 https://bugs.documentfoundation.org/show_bug.cgi?id=90441 |
||
| Whiteboard: | target:4.5.0 target:4.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
terminal output from crashing job
gdb on the core file bt with debug symbols |
||
Created attachment 109761 [details]
terminal output from crashing job
Created attachment 109762 [details]
gdb on the core file
Note that with somewhat longer set of steps, a segmentation fault
happened directly withing SfxItemPool::Put.
Because of skimpy symbols in the backtrace, I am not supplying keyword
have-backtrace.
Setting O/S All, as I also see the crash on Windows Vista running
Version: 4.4.0.0.alpha2+
Build ID: 4f18bd405831c31cd49190046f7bafd805a47d7d
TinderBox: Win-x86@39, Branch:master, Time: 2014-11-20_09:39:04
Locale: en_CA
Setting keywoard regression as there is no crash with daily dbgutil
bibisect version 2014-05-21.
Working in the daily dbgutil bibisect, I see from `git bisect bad`:
ea2725ba3b5e205d1ae628c7dc1b5335f5d463ad is the first bad commit
commit ea2725ba3b5e205d1ae628c7dc1b5335f5d463ad
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date: Thu Nov 6 09:22:12 2014 +0100
2014-11-06: source-hash-8b21b5cbe78945b27525b4ce78ae3d981f90590f
:100644 100644 99944723fc60c833ef869ec8ae8ccadc3c45bcc4 3601a2942c77454924406fd63e567c8c56abb0e2 M build-info.txt
:040000 040000 55b4ed43a8d22e2af12db913105a1053921fb10f a6cdcb75b71953d56688ea17a0fa4c0997c7f7ad M opt
and from `git bisect log`:
# bad: [05f4c71d4862a02ab81f09fcdd536c0cc6dfb128] 2014-11-20: source-hash-d273a60bfdbf9bb7623bed38667ec0647753157c
# good: [b3130c846de5cf1b4be48b48dfc780bb369549fa] 2014-05-21
git bisect start 'origin/master' 'oldest'
# good: [364ba817b97ce3b1d9ce53a2b51235cdb82d6864] 2014-08-21
git bisect good 364ba817b97ce3b1d9ce53a2b51235cdb82d6864
# good: [3bd90766c05c07c4a39e36cb1d3106b0016983d4] 2014-10-05
git bisect good 3bd90766c05c07c4a39e36cb1d3106b0016983d4
# good: [229fb435cbce6368a809b90a7aa176fb5bd4b0c2] 2014-10-28: source-hash-9997e60ba50483b791c5da3586f3372a3960f5ce
git bisect good 229fb435cbce6368a809b90a7aa176fb5bd4b0c2
# bad: [896c41d51775cfb52501476a17929817d15bf963] 2014-11-08: source-hash-c989f5e0e11e295b11ffc921b0d105869e037e47
git bisect bad 896c41d51775cfb52501476a17929817d15bf963
# skip: [fc496236778e821413024dc1e37361fc4d9ad23b] 2014-11-02: source-hash-06bde51ced10e9d2997157b91c85d80100b0dafb
git bisect skip fc496236778e821413024dc1e37361fc4d9ad23b
# good: [55b9e9c3f5adeb3aaba6f08e7b619552c03453a0] 2014-11-03: source-hash-d9473f25380c627966b4406cc4cdfaafcf44bc37
git bisect good 55b9e9c3f5adeb3aaba6f08e7b619552c03453a0
# good: [90a1c59acbcd8a2d11f6bf8d914af71fb558d849] 2014-11-05: source-hash-b7d8a58ff2698ffc6e22943f64aa97c5ea253bd9
git bisect good 90a1c59acbcd8a2d11f6bf8d914af71fb558d849
# bad: [7d3277fd5f4135e56eed30c6630f95d344dbbbf4] 2014-11-07: source-hash-0adb90115596ce69e1d80becdaa39e23197fe454
git bisect bad 7d3277fd5f4135e56eed30c6630f95d344dbbbf4
# bad: [ea2725ba3b5e205d1ae628c7dc1b5335f5d463ad] 2014-11-06: source-hash-8b21b5cbe78945b27525b4ce78ae3d981f90590f
git bisect bad ea2725ba3b5e205d1ae628c7dc1b5335f5d463ad
# first bad commit: [ea2725ba3b5e205d1ae628c7dc1b5335f5d463ad] 2014-11-06: source-hash-8b21b5cbe78945b27525b4ce78ae3d981f90590f
The skipped version, fc49623 ... 2014-11-02, crashed immediately when
I tried to open Tools menu.
Created attachment 109774 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
I attached a bt with symbols.
Michael: one for you? pretty obvious it's a regression from commit 4404b718bdb547cb9b7b17c73a53574724cdeeb7 Author: Daniel Sikeler <d.sikeler94@gmail.com> AuthorDate: Thu Oct 30 14:53:48 2014 +0000 Commit: Michael Stahl <mstahl@redhat.com> CommitDate: Wed Nov 5 11:50:42 2014 +0000 fdo#79761: parse BlockList.xml only once i've done a fix already with commit 5bff4b016c4b44f4123e0e6a4fd4c0c4dc0cfa2d but it looks like this crash is still happening :( let's see... how many stupid instance of the container of global variables anti-pattern do we have in writer... ah... moving the delete to ~SwDLL seems to help. fixed on master Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d47b674951aedd03815a3f27591b1791f7dfb52d fdo#86494: sw: fix crash on exit from SwAutoCorrect It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I see no crash with LibreOffice versions (*) daily dbgutil bibisect repo version 2014-11-22 (*) TinderBox: Win-x86@51-TDF, Branch:MASTER, Time: 2014-11-21_23:15:55 On each platform, the one-day-older version did crash. Once again, thank you, Michael. Terry. libreoffice-4-4 commit is 0b47dcdce3642e550cdf309b9d46431233cee41b *** Bug 86693 has been marked as a duplicate of this bug. *** *** Bug 74385 has been marked as a duplicate of this bug. *** Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |
STR (1) Run LO with command-line option --writer. Program opens Writer window "Untitled 1". (2) Take menu options Tools> "Autocorrect Options..." > Replace. Program displays dialog Autocorrect open either at tab Replace or at tab "Localized Options". (3) Click <Cancel>. Focus returns to "Untitled 1". (4) Close the program, discarding changes to "Untitled 1". Observe segmentation fault. These observations are from daily dbgutil bibisect repostiory version 2014-11-20 running in an environment chroot'ed to debian-sid.