| Summary: | FILESAVE: Saving as XLS file will cause calc to freeze | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Luke <lukebenes> |
| Component: | Calc | Assignee: | Matthew Francis <fdbugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fdbugs, raal |
| Priority: | medium | Keywords: | bibisectRequest, regression |
| Version: | 4.5.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.5.0 target:4.4.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Backtrace from deadlock | ||
I can confirm with Version: 4.4.0.0.alpha2+ Build ID: d273a60bfdbf9bb7623bed38667ec0647753157c TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-11-20_03:05:21 No freeze with LO 4.3.3.2, regression The hang started from this commit: Author: Michael Meeks <michael.meeks@collabora.com> Date: Thu Oct 30 22:51:59 2014 +0000 Thread excel table row/column format finalization. Change-Id: I6ddc0270831989291893b170d57fea14329a26ba Created attachment 110100 [details]
Backtrace from deadlock
Looks like the fact that the progress bar updates have been shifted to a helper thread is causing a deadlock
Matthew J. Francis committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d83b031346799bff0a3298387f76b16baad2e5cf fdo#86687 Avoid deadlock updating progress bar It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Matthew J. Francis committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e678a333c1f4a7a1bf8594d888938e598ed2f6a1&h=libreoffice-4-4 fdo#86687 Avoid deadlock updating progress bar It will be available in 4.4.0.0.beta2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Migrating Whiteboard tags to Keywords: (bibisectRequest) [NinjaEdit] |
Steps to Reproduce: 1. In a recent build of Calc 4.5, Open attachment 105590 [details] 2. File -> Save as -> *.xls Results: 4.2.6.3 - GOOD, saved correctly 4.5.0.0.alpha0+ - Freezes Calc