| Summary: | EDITING: Moving images in Draw, Impress, and Calc now uses constrain by default | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | tmacalp <tmacalp> |
| Component: | Draw | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cno, silvandy |
| Priority: | high | Keywords: | bibisected, regression |
| Version: | 4.4.0.1 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=83808 | ||
| Whiteboard: | target:4.5.0 target:4.4.1 target:4.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
tmacalp
2015-01-12 20:27:15 UTC
OSX 10.10.1 LO 4.4.0.2 WORKSFORME. Can you please rety? Which OS are you on? I tested this using 4.4.0.1 and 4.4.0.2 using 32bit Fedora 17, 64bit Fedora 20, and 64bit Arch Linux. Fedora 20 is where my bibisect environment is. The Arch machine is the only machine I have access to right now, and that version is: Version: 4.4.0.2 Build ID: a3603970151a6ae2596acd62b70112f4d376b990 Locale: en_US I can confirm that it does affect still affect this Arch version. So this might be Linux specific. I'll try to test on a MS Windows machine when I get a chance. I just tested this in 64bit MS Windows Vista (yuck), and I can confirm this bug affects LO there too, using: Version: 4.4.0.2 Build ID: a3603970151a6ae2596acd62b70112f4d376b990 Locale: en_US Maybe my steps to reproduce weren't clear enough. I'm inserting a jpg/png, clicking down on it, and immediately dragging it. This will cause the image to turn translucent while I'm dragging it around my screen. At that point, I move it in at least two axes and wiggle it around. It will stick to being lined up with the original image horizontally, vertically, or diagonally. Just as if you were holding down shift in versions <=4.3.x. Try holding shift to see if the behavior changes. Or maybe it doesn't affect OSX 10.10.1. I added a "see also" to the bug 83808 that caused this behavior, and added my comment. As I suspected, that was the enhancement that attempted to enable porportional image scaling by default for Calc, Impress, and Draw. It also enabled porportional image movement as well. Here is the Draw related commit, mentioned in that report: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef58e10844dff60cd218306b059ec81d8421f961 In the function "FuDraw::MouseMove" in source file /sd/source/ui/func/fudraw.cxx (the main function changed in the commit), the behavior can be fixed by changing the line: if(bIsImageSelected || (bRestricted && doConstructOrthogonal())) to if(bRestricted && (bIsImageSelected || doConstructOrthogonal())) This change fixes Draw and Impress. I'm guessing there is a similar change that needs to take place for the Calc commit, but that code doesn't seem as obvious to me. I submitted the patch mentioned above for review: https://gerrit.libreoffice.org/#/c/13900/ Note that this only applies to Draw and Impress. There will need to be another fix made in Calc. Trent MacAlpine committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6a1a8e6f8d97d24b4063909ef22824875326e28 fdo#88339 Fixed Draw/Impress constrained image movement It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I've submitted another patch that should take care of this behavior in Calc. https://gerrit.libreoffice.org/#/c/13975/ At this point, I'm pretty sure this bug is valid, so I'll change the status from NEEDINFO back to NEW until the patch is accepted. Trent MacAlpine committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4ce891c59a9ab47cfde5fedb89b7d4b19002fae8&h=libreoffice-4-4 fdo#88339 Fixed Draw/Impress constrained image movement It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Trent MacAlpine committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a4a68e2515fa54e041004cf63042c1ead00d576 fdo#88339 Fixed Calc constrained image movement It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #8) > fdo#88339 Fixed Draw/Impress constrained image movement > > It will be available in 4.4.1. Great :) Thanks! The Calc related patch was merged to master this morning, so I just submitted its twin to 4.4 for review. Hopefully we'll see that one in 4.4.1 too. Though I'm still waiting on that last patch to be reviewed for 4.4, master is already fixed. So I'll be impatient and mark as resolved fixed! :) Trent MacAlpine committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fdff4b60b6d4beabadab15a4fceb60cb84e542d8&h=libreoffice-4-4 fdo#88339 Fixed Calc constrained image movement It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef9d28a3605b7e3e1e68212cc44f7379fd2f464a it's unnecessary to obtain the marked object in move mode, fdo#88339 followup It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Trent MacAlpine committed a patch related to this issue. It has been pushed to "libreoffice-4-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5417429d0ef2d968b227dd2a533c1bf9cb0156b9&h=libreoffice-4-4-0 fdo#88339 Fixed Calc constrained image movement It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 88684 has been marked as a duplicate of this bug. *** Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit] |